fix(ComboBox): save onInputChange in ref

carbon-design-system · Apr 30, 2021 · f9efcc7 · f9efcc7
1 parent 7eaad2b
commit f9efcc7
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/packages/react/src/components/ComboBox/ComboBox.js b/packages/react/src/components/ComboBox/ComboBox.js
@@ -113,6 +113,7 @@ const ComboBox = (props) => {
   );
   const [prevSelectedItem, setPrevSelectedItem] = useState(null);
   const [doneInitialSelectedItem, setDoneInitialSelectedItem] = useState(null);
+  const savedOnInputChange = useRef(onInputChange);
 
   if (!doneInitialSelectedItem || prevSelectedItem !== selectedItem) {
     setDoneInitialSelectedItem(true);
@@ -147,10 +148,10 @@ const ComboBox = (props) => {
   };
 
   useEffect(() => {
-    if (onInputChange) {
-      onInputChange(inputValue);
+    if (savedOnInputChange.current) {
+      savedOnInputChange.current(inputValue);
     }
-  }, [onInputChange, inputValue]);
+  }, [inputValue]);
 
   const handleSelectionClear = () => {
     if (textInput?.current) {