fix(Modal): edit close icon alt text to match content guidelines (#5700)

carbon-design-system · Apr 1, 2020 · f51b06b · f51b06b
1 parent e83aabf
commit f51b06b
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 17 deletions.
diff --git a/packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap b/packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap
@@ -2948,7 +2948,7 @@ Map {
   "Modal" => Object {
     "defaultProps": Object {
       "hasScrollingContent": false,
-      "iconDescription": "close the modal",
+      "iconDescription": "Close",
       "modalHeading": "",
       "modalLabel": "",
       "onKeyDown": [Function],

diff --git a/packages/react/src/components/Modal/Modal-story.js b/packages/react/src/components/Modal/Modal-story.js
@@ -55,10 +55,7 @@ const props = () => ({
     '[data-modal-primary-focus]'
   ),
   size: select('Size (size)', sizes),
-  iconDescription: text(
-    'Close icon description (iconDescription)',
-    'Close the modal'
-  ),
+  iconDescription: text('Close icon description (iconDescription)', 'Close'),
   onBlur: action('onBlur'),
   onClick: action('onClick'),
   onFocus: action('onFocus'),
@@ -93,10 +90,7 @@ const titleOnlyProps = () => {
       'Secondary Button'
     ),
     size: select('Size (size)', sizes, 'sm'),
-    iconDescription: text(
-      'Close icon description (iconDescription)',
-      'Close the modal'
-    ),
+    iconDescription: text('Close icon description (iconDescription)', 'Close'),
     onBlur: action('onBlur'),
     onClick: action('onClick'),
     onFocus: action('onFocus'),

diff --git a/packages/react/src/components/Modal/Modal-test.js b/packages/react/src/components/Modal/Modal-test.js
@@ -49,7 +49,7 @@ describe('Modal', () => {
     });
 
     it('has the expected default iconDescription', () => {
-      expect(mounted.props().iconDescription).toEqual('close the modal');
+      expect(mounted.props().iconDescription).toEqual('Close');
     });
 
     it('adds new iconDescription when passed via props', () => {

diff --git a/packages/react/src/components/Modal/Modal.js b/packages/react/src/components/Modal/Modal.js
@@ -169,7 +169,7 @@ export default class Modal extends Component {
     primaryButtonDisabled: false,
     onKeyDown: () => {},
     passiveModal: false,
-    iconDescription: 'close the modal',
+    iconDescription: 'Close',
     modalHeading: '',
     modalLabel: '',
     selectorPrimaryFocus: '[data-modal-primary-focus]',

diff --git a/packages/react/src/components/ModalWrapper/__snapshots__/ModalWrapper-test.js.snap b/packages/react/src/components/ModalWrapper/__snapshots__/ModalWrapper-test.js.snap
@@ -44,7 +44,7 @@ exports[`ModalWrapper should render 1`] = `
     <Modal
       aria-label="test modal"
       hasScrollingContent={false}
-      iconDescription="close the modal"
+      iconDescription="Close"
       id="modal"
       modalHeading="Transactional Modal"
       modalLabel="Test Modal Label"
@@ -97,18 +97,18 @@ exports[`ModalWrapper should render 1`] = `
               Transactional Modal
             </h3>
             <button
-              aria-label="close the modal"
+              aria-label="Close"
               className="bx--modal-close"
               onClick={[Function]}
-              title="close the modal"
+              title="Close"
               type="button"
             >
               <ForwardRef(Close20)
-                aria-label="close the modal"
+                aria-label="Close"
                 className="bx--modal-close__icon"
               >
                 <Icon
-                  aria-label="close the modal"
+                  aria-label="Close"
                   className="bx--modal-close__icon"
                   height={20}
                   preserveAspectRatio="xMidYMid meet"
@@ -117,7 +117,7 @@ exports[`ModalWrapper should render 1`] = `
                   xmlns="http://www.w3.org/2000/svg"
                 >
                   <svg
-                    aria-label="close the modal"
+                    aria-label="Close"
                     className="bx--modal-close__icon"
                     focusable="false"
                     height={20}