Skip to content

Commit

Permalink
fix(structured-list): remove unused prop
Browse files Browse the repository at this point in the history
  • Loading branch information
tw15egan committed Mar 10, 2020
1 parent b8187fa commit d76eacf
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 32 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ storiesOf('StructuredList', module)
));
};
return (
<StructuredListWrapper selection border>
<StructuredListWrapper selection>
<StructuredListHead>
<StructuredListRow head>
<StructuredListCell head>ColumnA</StructuredListCell>
Expand Down Expand Up @@ -125,7 +125,7 @@ storiesOf('StructuredList', module)
() => (
<div style={{ width: '800px' }}>
<StructuredListSkeleton />
<StructuredListSkeleton border />
<StructuredListSkeleton />
</div>
),
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,27 +33,12 @@ describe('StructuredListWrapper', () => {
expect(wrapper.hasClass('extra-class')).toEqual(true);
});

it('By default, border prop is false', () => {
wrapper.setProps({ border: false });
expect(wrapper.hasClass(`${prefix}--structured-list--border`)).toEqual(
false
);
});

it('By default, selection prop is false', () => {
wrapper.setProps({ border: false });
expect(wrapper.hasClass(`${prefix}--structured-list--selection`)).toEqual(
false
);
});

it('Should add the modifier class for border when border prop is true', () => {
wrapper.setProps({ border: true });
expect(wrapper.hasClass(`${prefix}--structured-list--border`)).toEqual(
true
);
});

it('Should add the modifier class for selection when selection prop is true', () => {
wrapper.setProps({ selection: true });
expect(wrapper.hasClass(`${prefix}--structured-list--selection`)).toEqual(
Expand Down
16 changes: 1 addition & 15 deletions packages/react/src/components/StructuredList/StructuredList.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@ export class StructuredListWrapper extends Component {
*/
className: PropTypes.string,

/**
* Specify whether a border should be added to your StructuredListWrapper
*/
border: PropTypes.bool,

/**
* Specify whether your StructuredListWrapper should have selections
*/
Expand All @@ -42,23 +37,14 @@ export class StructuredListWrapper extends Component {
};

static defaultProps = {
border: false,
selection: false,
ariaLabel: 'Structured list section',
};

render() {
const {
children,
selection,
className,
border,
ariaLabel,
...other
} = this.props;
const { children, selection, className, ariaLabel, ...other } = this.props;

const classes = classNames(`${prefix}--structured-list`, className, {
[`${prefix}--structured-list--border`]: border,
[`${prefix}--structured-list--selection`]: selection,
});

Expand Down

0 comments on commit d76eacf

Please sign in to comment.