Skip to content

Commit

Permalink
fix(NumberInput.js): assign min and max value to default props (#12768)
Browse files Browse the repository at this point in the history
Co-authored-by: TJ Egan <[email protected]>
  • Loading branch information
darioplatania and tw15egan authored Dec 6, 2022
1 parent af164af commit b623958
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
9 changes: 9 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -968,6 +968,15 @@
"contributions": [
"code"
]
},
{
"login": "darioplatania",
"name": "dario platania",
"avatar_url": "https://avatars.githubusercontent.com/u/11682859?v=4",
"profile": "http://darioplatania.github.io/",
"contributions": [
"code"
]
}
],
"commitConvention": "none"
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ check out our [Contributing Guide](/.github/CONTRIBUTING.md) and our
</tr>
<tr>
<td align="center"><a href="https://github.com/Shankar-CodeJunkie"><img src="https://avatars.githubusercontent.com/u/56068832?v=4?s=100" width="100px;" alt=""/><br /><sub><b>ShankarV-CodeJunkie</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=Shankar-CodeJunkie" title="Code">💻</a></td>
<td align="center"><a href="http://darioplatania.github.io/"><img src="https://avatars.githubusercontent.com/u/11682859?v=4?s=100" width="100px;" alt=""/><br /><sub><b>dario platania</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=darioplatania" title="Code">💻</a></td>
</tr>
</table>

Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/components/NumberInput/NumberInput.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ const NumberInput = React.forwardRef(function NumberInput(props, forwardRef) {
invalid = false,
invalidText = enabled ? undefined : 'Provide invalidText',
light,
max,
min,
max = 100,
min = 0,
onChange,
onClick,
onKeyUp,
Expand Down

0 comments on commit b623958

Please sign in to comment.