Skip to content

Commit

Permalink
chore: use header tag in Popover component (#14943)
Browse files Browse the repository at this point in the history
use <h2> tag in the 'Available storage' headers in the Popover component
  • Loading branch information
allisonishida authored Oct 23, 2023
1 parent 0da8e6b commit a7f9365
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 6 deletions.
9 changes: 9 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -1278,6 +1278,15 @@
"code",
"doc"
]
},
{
"login": "allisonishida",
"name": "Allison Ishida",
"avatar_url": "https://avatars.githubusercontent.com/u/22247062?v=4",
"profile": "https://github.com/allisonishida",
"contributions": [
"code"
]
}
],
"commitConvention": "none"
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ check out our [Contributing Guide](/.github/CONTRIBUTING.md) and our
<td align="center"><a href="https://med-aziz-chebbi.web.app/"><img src="https://avatars.githubusercontent.com/u/60013060?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Aziz Chebbi</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=azizChebbi" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/misiekhardcore"><img src="https://avatars.githubusercontent.com/u/58469680?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Michał Konopski</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=misiekhardcore" title="Code">💻</a></td>
<td align="center"><a href="https://github.com/amanlajpal"><img src="https://avatars.githubusercontent.com/u/42869088?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Aman Lajpal</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=amanlajpal" title="Code">💻</a> <a href="https://github.com/carbon-design-system/carbon/commits?author=amanlajpal" title="Documentation">📖</a></td>
<td align="center"><a href="https://github.com/allisonishida"><img src="https://avatars.githubusercontent.com/u/22247062?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Allison Ishida</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=allisonishida" title="Code">💻</a></td>
</tr>
</table>

Expand Down
12 changes: 6 additions & 6 deletions packages/react/src/components/Popover/Popover.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ const PlaygroundStory = (props) => {
<CheckboxIcon />
</div>
<PopoverContent className="p-3">
<p className="popover-title">Available storage</p>
<h2 className="popover-title">Available storage</h2>
<p className="popover-details">
This server has 150 GB of block storage remaining.
</p>
Expand Down Expand Up @@ -246,7 +246,7 @@ export const AutoAlign = () => {
/>
</div>
<PopoverContent className="p-3">
<p className="popover-title">Available storage</p>
<h2 className="popover-title">Available storage</h2>
<p className="popover-details">
This server has 150 GB of block storage remaining.
</p>
Expand All @@ -258,7 +258,7 @@ export const AutoAlign = () => {
<CheckboxIcon />
</div>
<PopoverContent className="p-3">
<p className="popover-title">Available storage</p>
<h2 className="popover-title">Available storage</h2>
<p className="popover-details">
This server has 150 GB of block storage remaining.
</p>
Expand All @@ -277,7 +277,7 @@ export const AutoAlign = () => {
<CheckboxIcon />
</div>
<PopoverContent className="p-3">
<p className="popover-title">Available storage</p>
<h2 className="popover-title">Available storage</h2>
<p className="popover-details">
This server has 350 GB of block storage remaining.
</p>
Expand All @@ -297,7 +297,7 @@ export const AutoAlign = () => {
<CheckboxIcon />
</div>
<PopoverContent className="p-3">
<p className="popover-title">Available storage</p>
<h2 className="popover-title">Available storage</h2>
<p className="popover-details">
This server has 150 GB of block storage remaining.
</p>
Expand All @@ -317,7 +317,7 @@ export const AutoAlign = () => {
<CheckboxIcon />
</div>
<PopoverContent className="p-3">
<p className="popover-title">Available storage</p>
<h2 className="popover-title">Available storage</h2>
<p className="popover-details">
This server has 150 GB of block storage remaining.
</p>
Expand Down

0 comments on commit a7f9365

Please sign in to comment.