Skip to content

Commit

Permalink
Merge branch 'master' into chore/clean-up-aat-artifacts
Browse files Browse the repository at this point in the history
  • Loading branch information
andreancardona authored Jan 12, 2021
2 parents 8be5165 + eee0a96 commit 5e80a91
Show file tree
Hide file tree
Showing 29 changed files with 320 additions and 183 deletions.
Binary file not shown.
2 changes: 1 addition & 1 deletion config/storybook-preset-carbon/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "storybook-preset-carbon",
"private": true,
"version": "0.1.0-rc.0",
"version": "0.1.0",
"license": "Apache-2.0",
"main": "index.js",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/bundler/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@carbon/bundler",
"description": "Bundler used for libraries in the Carbon Design System",
"version": "10.11.0-rc.0",
"version": "10.11.0",
"license": "Apache-2.0",
"bin": "./bin/bundler.js",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@carbon/cli",
"description": "Task automation for working with the Carbon Design System",
"version": "10.17.0-rc.0",
"version": "10.17.0",
"license": "Apache-2.0",
"bin": {
"carbon-cli": "./bin/carbon-cli.js"
Expand Down
4 changes: 2 additions & 2 deletions packages/colors/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@carbon/colors",
"description": "Colors for digital and software products using the Carbon Design System",
"version": "10.18.0-rc.0",
"version": "10.18.0",
"license": "Apache-2.0",
"main": "lib/index.js",
"module": "es/index.js",
Expand Down Expand Up @@ -35,7 +35,7 @@
"clean": "rimraf css es lib umd scss"
},
"devDependencies": {
"@carbon/bundler": "^10.11.0-rc.0",
"@carbon/bundler": "^10.11.0",
"@carbon/cli-reporter": "^10.4.0",
"@carbon/scss-generator": "^10.11.0",
"@carbon/test-utils": "^10.13.0",
Expand Down
76 changes: 52 additions & 24 deletions packages/components/docs/sass.md
Original file line number Diff line number Diff line change
Expand Up @@ -18735,12 +18735,9 @@ Data table core styles
vertical-align: middle;
}

.#{$prefix}--data-table td {
.#{$prefix}--data-table th {
padding-right: $spacing-05;
padding-left: $spacing-05;
}

.#{$prefix}--data-table th {
color: $text-01;
background-color: $ui-03;
}
Expand All @@ -18752,8 +18749,6 @@ Data table core styles
}

.#{$prefix}--data-table .#{$prefix}--table-header-label {
padding-right: $spacing-05;
padding-left: $spacing-05;
text-align: left;
}

Expand Down Expand Up @@ -18920,22 +18915,40 @@ Data table core styles
.#{$prefix}--data-table thead th.#{$prefix}--table-expand,
.#{$prefix}--data-table tbody td.#{$prefix}--table-expand {
min-width: 0;
// spacing between checkbox / chevron and next cell should be 16px / 1rem
// adjacent cell has 16px / 1rem padding-left though, hence the removal of padding-right here
padding-right: 0;
padding-left: $spacing-05;
}

.#{$prefix}--data-table thead th.#{$prefix}--table-column-checkbox,
.#{$prefix}--data-table tbody td.#{$prefix}--table-column-checkbox {
// 16px padding left + 20px checkbox width
width: rem(36px);
width: rem(16px);
// spacing between checkbox / chevron and next cell should be 16px / 1rem
// adjacent cell has 16px / 1rem padding-left though, hence the removal of padding-right here
padding-right: $spacing-05;
padding-left: $spacing-05;
}

.#{$prefix}--data-table thead th.#{$prefix}--table-expand,
.#{$prefix}--data-table tbody td.#{$prefix}--table-expand {
// 16px padding left + 16px checkbox width
width: rem(48px);
height: rem(48px);
}

.#{$prefix}--data-table--compact thead th.#{$prefix}--table-expand,
.#{$prefix}--data-table--compact tbody td.#{$prefix}--table-expand {
width: rem(24px);
height: rem(24px);
}

.#{$prefix}--data-table--short thead th.#{$prefix}--table-expand,
.#{$prefix}--data-table--short tbody td.#{$prefix}--table-expand {
width: rem(32px);
height: rem(32px);
}

.#{$prefix}--data-table--tall thead th.#{$prefix}--table-expand,
.#{$prefix}--data-table--tall tbody td.#{$prefix}--table-expand {
width: rem(64px);
height: rem(64px);
}

.#{$prefix}--data-table--tall .#{$prefix}--table-column-checkbox {
Expand Down Expand Up @@ -19546,20 +19559,26 @@ Data table expandable styles
// Expand icon column
//----------------------------------------------------------------------------
.#{$prefix}--data-table td.#{$prefix}--table-expand {
width: 2.5rem;
min-width: 2.5rem;
border-bottom: 1px solid $ui-03;
}

.#{$prefix}--data-table td.#{$prefix}--table-expand,
th.#{$prefix}--table-expand {
padding: 0 $spacing-05;
.#{$prefix}--data-table th.#{$prefix}--table-expand + th,
.#{$prefix}--data-table td.#{$prefix}--table-expand + td {
padding-left: 0;
}

.#{$prefix}--data-table--tall td.#{$prefix}--table-expand,
.#{$prefix}--data-table--tall th.#{$prefix}--table-expand {
padding-top: rem(16px);
padding-bottom: rem(16px);
.#{$prefix}--data-table
th.#{$prefix}--table-expand
+ .#{$prefix}--table-column-checkbox,
.#{$prefix}--data-table
td.#{$prefix}--table-expand
+ .#{$prefix}--table-column-checkbox {
padding-right: 0;
}

.#{$prefix}--data-table td.#{$prefix}--table-expand,
.#{$prefix}--data-table th.#{$prefix}--table-expand {
padding: 0;
}

.#{$prefix}--data-table
Expand All @@ -19576,17 +19595,21 @@ Data table expandable styles
.#{$prefix}--table-expand__button {
@include button-reset('false');

height: rem(16px);
display: inline-flex;
align-items: center;
justify-content: center;
width: 100%;
// Account for the border in `.bx--table-expand`
height: calc(100% + 1px);
vertical-align: inherit;
}

.#{$prefix}--table-expand__button:focus {
outline: none;
box-shadow: inset 0 0 0 2px $focus;
}

.#{$prefix}--table-expand__button:focus .#{$prefix}--table-expand__svg {
box-shadow: inset 0 0 0 2px $focus;

// Windows, Firefox HCM Fix
@media screen and (-ms-high-contrast: active),
screen and (prefers-contrast) {
Expand All @@ -19607,6 +19630,11 @@ Data table expandable styles
}
}

.#{$prefix}--data-table--tall .#{$prefix}--table-expand__button {
padding-top: rem(16px);
padding-bottom: rem(24px);
}

// fix expanded parent separating border length
tr.#{$prefix}--parent-row.#{$prefix}--expandable-row
td.#{$prefix}--table-expand
Expand Down
10 changes: 5 additions & 5 deletions packages/components/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "carbon-components",
"description": "The Carbon Design System is IBM’s open-source design system for products and experiences.",
"version": "10.26.0-rc.0",
"version": "10.26.0",
"license": "Apache-2.0",
"main": "umd/index.js",
"module": "es/index.js",
Expand Down Expand Up @@ -83,10 +83,10 @@
"@babel/preset-env": "^7.10.0",
"@babel/preset-react": "^7.10.0",
"@babel/runtime": "^7.10.0",
"@carbon/bundler": "^10.11.0-rc.0",
"@carbon/elements": "^10.25.0-rc.0",
"@carbon/icons-handlebars": "^10.23.0-rc.0",
"@carbon/icons-react": "^10.23.0-rc.0",
"@carbon/bundler": "^10.11.0",
"@carbon/elements": "^10.25.0",
"@carbon/icons-handlebars": "^10.23.0",
"@carbon/icons-react": "^10.23.0",
"@carbon/test-utils": "^10.13.0",
"@frctl/fractal": "^1.1.0",
"adaro": "1.0.4",
Expand Down
37 changes: 25 additions & 12 deletions packages/components/src/components/data-table/_data-table-core.scss
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,9 @@
vertical-align: middle;
}

.#{$prefix}--data-table td {
.#{$prefix}--data-table th {
padding-right: $spacing-05;
padding-left: $spacing-05;
}

.#{$prefix}--data-table th {
color: $text-01;
background-color: $ui-03;
}
Expand All @@ -115,8 +112,6 @@
}

.#{$prefix}--data-table .#{$prefix}--table-header-label {
padding-right: $spacing-05;
padding-left: $spacing-05;
text-align: left;
}

Expand Down Expand Up @@ -283,22 +278,40 @@
.#{$prefix}--data-table thead th.#{$prefix}--table-expand,
.#{$prefix}--data-table tbody td.#{$prefix}--table-expand {
min-width: 0;
// spacing between checkbox / chevron and next cell should be 16px / 1rem
// adjacent cell has 16px / 1rem padding-left though, hence the removal of padding-right here
padding-right: 0;
padding-left: $spacing-05;
}

.#{$prefix}--data-table thead th.#{$prefix}--table-column-checkbox,
.#{$prefix}--data-table tbody td.#{$prefix}--table-column-checkbox {
// 16px padding left + 20px checkbox width
width: rem(36px);
width: rem(16px);
// spacing between checkbox / chevron and next cell should be 16px / 1rem
// adjacent cell has 16px / 1rem padding-left though, hence the removal of padding-right here
padding-right: $spacing-05;
padding-left: $spacing-05;
}

.#{$prefix}--data-table thead th.#{$prefix}--table-expand,
.#{$prefix}--data-table tbody td.#{$prefix}--table-expand {
// 16px padding left + 16px checkbox width
width: rem(48px);
height: rem(48px);
}

.#{$prefix}--data-table--compact thead th.#{$prefix}--table-expand,
.#{$prefix}--data-table--compact tbody td.#{$prefix}--table-expand {
width: rem(24px);
height: rem(24px);
}

.#{$prefix}--data-table--short thead th.#{$prefix}--table-expand,
.#{$prefix}--data-table--short tbody td.#{$prefix}--table-expand {
width: rem(32px);
height: rem(32px);
}

.#{$prefix}--data-table--tall thead th.#{$prefix}--table-expand,
.#{$prefix}--data-table--tall tbody td.#{$prefix}--table-expand {
width: rem(64px);
height: rem(64px);
}

.#{$prefix}--data-table--tall .#{$prefix}--table-column-checkbox {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -161,20 +161,26 @@
// Expand icon column
//----------------------------------------------------------------------------
.#{$prefix}--data-table td.#{$prefix}--table-expand {
width: 2.5rem;
min-width: 2.5rem;
border-bottom: 1px solid $ui-03;
}

.#{$prefix}--data-table td.#{$prefix}--table-expand,
th.#{$prefix}--table-expand {
padding: 0 $spacing-05;
.#{$prefix}--data-table th.#{$prefix}--table-expand + th,
.#{$prefix}--data-table td.#{$prefix}--table-expand + td {
padding-left: 0;
}

.#{$prefix}--data-table--tall td.#{$prefix}--table-expand,
.#{$prefix}--data-table--tall th.#{$prefix}--table-expand {
padding-top: rem(16px);
padding-bottom: rem(16px);
.#{$prefix}--data-table
th.#{$prefix}--table-expand
+ .#{$prefix}--table-column-checkbox,
.#{$prefix}--data-table
td.#{$prefix}--table-expand
+ .#{$prefix}--table-column-checkbox {
padding-right: 0;
}

.#{$prefix}--data-table td.#{$prefix}--table-expand,
.#{$prefix}--data-table th.#{$prefix}--table-expand {
padding: 0;
}

.#{$prefix}--data-table
Expand All @@ -191,17 +197,21 @@
.#{$prefix}--table-expand__button {
@include button-reset('false');

height: rem(16px);
display: inline-flex;
align-items: center;
justify-content: center;
width: 100%;
// Account for the border in `.bx--table-expand`
height: calc(100% + 1px);
vertical-align: inherit;
}

.#{$prefix}--table-expand__button:focus {
outline: none;
box-shadow: inset 0 0 0 2px $focus;
}

.#{$prefix}--table-expand__button:focus .#{$prefix}--table-expand__svg {
box-shadow: inset 0 0 0 2px $focus;

// Windows, Firefox HCM Fix
@media screen and (-ms-high-contrast: active),
screen and (prefers-contrast) {
Expand All @@ -222,6 +232,11 @@
}
}

.#{$prefix}--data-table--tall .#{$prefix}--table-expand__button {
padding-top: rem(16px);
padding-bottom: rem(24px);
}

// fix expanded parent separating border length
tr.#{$prefix}--parent-row.#{$prefix}--expandable-row
td.#{$prefix}--table-expand
Expand Down
18 changes: 9 additions & 9 deletions packages/elements/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@carbon/elements",
"description": "A collection of design elements in code for the IBM Design Language",
"version": "10.25.0-rc.0",
"version": "10.25.0",
"license": "Apache-2.0",
"main": "lib/index.js",
"module": "es/index.js",
Expand Down Expand Up @@ -35,17 +35,17 @@
"clean": "rimraf es lib umd && node tasks/clean.js"
},
"dependencies": {
"@carbon/colors": "^10.18.0-rc.0",
"@carbon/grid": "^10.18.0-rc.0",
"@carbon/icons": "^10.23.0-rc.0",
"@carbon/colors": "^10.18.0",
"@carbon/grid": "^10.18.0",
"@carbon/icons": "^10.23.0",
"@carbon/import-once": "^10.4.0",
"@carbon/layout": "^10.16.0-rc.0",
"@carbon/motion": "^10.11.0-rc.0",
"@carbon/themes": "^10.25.0-rc.0",
"@carbon/type": "^10.19.0-rc.0"
"@carbon/layout": "^10.16.0",
"@carbon/motion": "^10.11.0",
"@carbon/themes": "^10.25.0",
"@carbon/type": "^10.19.0"
},
"devDependencies": {
"@carbon/bundler": "^10.11.0-rc.0",
"@carbon/bundler": "^10.11.0",
"fs-extra": "^8.1.0",
"klaw-sync": "^6.0.0",
"replace-in-file": "^3.4.2",
Expand Down
Loading

0 comments on commit 5e80a91

Please sign in to comment.