refactor(TooltipIcon): place keydown handler in useEffect block

carbon-design-system · Jan 27, 2020 · 40443b1 · 40443b1
1 parent ef0ec93
commit 40443b1
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/packages/react/src/components/TooltipIcon/TooltipIcon.js b/packages/react/src/components/TooltipIcon/TooltipIcon.js
@@ -39,13 +39,13 @@ const TooltipIcon = ({
     }
   );
   const handleFocus = () => setAllowTooltipVisibility(true);
-  const handleEscKeyDown = event => {
-    if (matches(event, [keys.Escape])) {
-      setAllowTooltipVisibility(false);
-    }
-  };
   const handleMouseEnter = () => setAllowTooltipVisibility(true);
   useEffect(() => {
+    const handleEscKeyDown = event => {
+      if (matches(event, [keys.Escape])) {
+        setAllowTooltipVisibility(false);
+      }
+    };
     document.addEventListener('keydown', handleEscKeyDown);
     return () => document.removeEventListener('keydown', handleEscKeyDown);
   }, []);