Skip to content

Commit

Permalink
fix(styles): remove hardcoded prefixes (#9321)
Browse files Browse the repository at this point in the history
* fix(styles): remove hardcoded prefixes

* fix(ListBox): fix listbox selector

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
  • Loading branch information
tw15egan and kodiakhq[bot] authored Jul 28, 2021
1 parent 0b68ca7 commit 354bf5c
Show file tree
Hide file tree
Showing 11 changed files with 24 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -968,7 +968,8 @@
// -------------------
// with boolean column
// -------------------
.#{$prefix}--data-table .bx--form-item.bx--checkbox-wrapper:last-of-type {
.#{$prefix}--data-table
.#{$prefix}--form-item.#{$prefix}--checkbox-wrapper:last-of-type {
margin: 0;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/list-box/_list-box.scss
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ $list-box-menu-width: rem(300px);
max-width: rem(480px);
}

.#{$prefix}--dropdown--inline .bx--list-box__menu {
.#{$prefix}--dropdown--inline .#{$prefix}--list-box__menu {
min-width: rem(288px);
max-width: rem(480px);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,9 @@
}

//No label positioning adjustment
.#{$prefix}--number--nolabel .bx--label + .bx--form__helper-text {
.#{$prefix}--number--nolabel
.#{$prefix}--label
+ .#{$prefix}--form__helper-text {
margin-top: 0;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,9 @@
white-space: initial;
}

.#{$prefix}--progress--vertical .#{$prefix}--progress-step .bx--tooltip {
.#{$prefix}--progress--vertical
.#{$prefix}--progress-step
.#{$prefix}--tooltip {
margin-top: 0.5rem;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/ui-shell/_side-nav.scss
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
width: 0;
}

.#{$prefix}--side-nav.bx--side-nav--rail:not(.#{$prefix}--side-nav--fixed):hover,
.#{$prefix}--side-nav.#{$prefix}--side-nav--rail:not(.#{$prefix}--side-nav--fixed):hover,
.#{$prefix}--side-nav--expanded {
width: mini-units(32);
}
Expand Down
3 changes: 2 additions & 1 deletion packages/styles/scss/components/data-table/_data-table.scss
Original file line number Diff line number Diff line change
Expand Up @@ -969,7 +969,8 @@
// -------------------
// with boolean column
// -------------------
.#{$prefix}--data-table .bx--form-item.bx--checkbox-wrapper:last-of-type {
.#{$prefix}--data-table
.#{$prefix}--form-item.#{$prefix}--checkbox-wrapper:last-of-type {
margin: 0;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/styles/scss/components/list-box/_list-box.scss
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ $list-box-menu-width: rem(300px);
max-width: rem(480px);
}

.#{$prefix}--dropdown--inline .bx--list-box__menu {
.#{$prefix}--dropdown--inline .#{$prefix}--list-box__menu {
min-width: rem(288px);
max-width: rem(480px);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,9 @@
}

//No label positioning adjustment
.#{$prefix}--number--nolabel .bx--label + .bx--form__helper-text {
.#{$prefix}--number--nolabel
.#{$prefix}--label
+ .#{$prefix}--form__helper-text {
margin-top: 0;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,9 @@ $progress-indicator-bar-width: 1px inset transparent !default;
white-space: initial;
}

.#{$prefix}--progress--vertical .#{$prefix}--progress-step .bx--tooltip {
.#{$prefix}--progress--vertical
.#{$prefix}--progress-step
.#{$prefix}--tooltip {
margin-top: 0.5rem;
}

Expand Down
8 changes: 4 additions & 4 deletions packages/styles/scss/components/ui-shell/header/_header.scss
Original file line number Diff line number Diff line change
Expand Up @@ -83,16 +83,16 @@
justify-content: center;
}

.bx--btn.bx--btn--icon-only.bx--tooltip__trigger.#{$prefix}--header__action
.#{$prefix}--btn.#{$prefix}--btn--icon-only.#{$prefix}--tooltip__trigger.#{$prefix}--header__action
svg {
fill: $icon-secondary;
}

.bx--btn.bx--btn--icon-only.bx--tooltip__trigger.#{$prefix}--header__action:hover
.#{$prefix}--btn.#{$prefix}--btn--icon-only.#{$prefix}--tooltip__trigger.#{$prefix}--header__action:hover
svg,
.bx--btn.bx--btn--icon-only.bx--tooltip__trigger.#{$prefix}--header__action:active
.#{$prefix}--btn.#{$prefix}--btn--icon-only.#{$prefix}--tooltip__trigger.#{$prefix}--header__action:active
svg,
.bx--btn.bx--btn--icon-only.bx--tooltip__trigger.#{$prefix}--header__action--active
.#{$prefix}--btn.#{$prefix}--btn--icon-only.#{$prefix}--tooltip__trigger.#{$prefix}--header__action--active
svg {
fill: $icon-primary;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
width: 0;
}

.#{$prefix}--side-nav.bx--side-nav--rail:not(.#{$prefix}--side-nav--fixed):hover,
.#{$prefix}--side-nav.#{$prefix}--side-nav--rail:not(.#{$prefix}--side-nav--fixed):hover,
.#{$prefix}--side-nav--expanded {
width: mini-units(32);
}
Expand Down

0 comments on commit 354bf5c

Please sign in to comment.