-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(docs) Content template: updated style sections #4197
(docs) Content template: updated style sections #4197
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @aagonzales
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks really good, and its working well for my Pagination Style tab docs!
Going to approve and I think one thing you could add to the Typography section is to be more explicit about how to treat different variants that have different type specs, since Pagination ran into that issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aagonzales! This looks great. 🔥
I just wanted to confirm one small thing: the current docs mention "interactive state," but in the updated document templated, it says "interactive state color." Which one is correct? As this could lead to changes in almost all the components' docs.
@Kritvi-bhatia17 oh yes good catch. I think Aubrey changed it to "interactive state color" the last time she updated the template so I just kept it that way. You are right to point out its inconsistent with what's showing in most docs. We probably need to do a content scrub to make sure all our style tabs will reflect the new template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Closes #4180
Updated the content template to include a section for
Style tab with multiple variants
Changelog
New
Changed