Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(color): add missing support tokens #4193

Merged
merged 1 commit into from
Aug 9, 2024
Merged

docs(color): add missing support tokens #4193

merged 1 commit into from
Aug 9, 2024

Conversation

janhassel
Copy link
Member

Changelog

New

  • Added missing support tokens:
    • $support-caution-minor
    • $support-caution-major
    • $support-caution-undefined

Changed

  • Added the missing shade ("30") to existing $support-warning and $support-warning-inverse color name

Removed

  • Removed "Caution" as use case for $support-warning

@janhassel janhassel requested review from a team as code owners August 8, 2024 14:13
@vercel Vercel
Copy link

vercel bot commented Aug 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 2:19pm

emyarod
emyarod approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

aagonzales
aagonzales approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for updating!

@kodiakhq kodiakhq bot merged commit 733851f into carbon-design-system:main Aug 9, 2024
7 checks passed
@janhassel janhassel deleted the missing-support-tokens branch August 12, 2024 06:54
@Kritvi-bhatia17
Copy link
Contributor

Closes #3683

@Kritvi-bhatia17 Kritvi-bhatia17 mentioned this pull request Sep 23, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aagonzales aagonzales aagonzales approved these changes

@emyarod emyarod emyarod approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@janhassel @Kritvi-bhatia17 @emyarod @aagonzales