-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Selectable Components: Structured List - Style] Website Doc #3965
[Selectable Components: Structured List - Style] Website Doc #3965
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good Kritvi! Just some comments below:
Structure section
- Since you are showing the hang and flush structured list specs in the image, the table above it also needs to have some information for the flush list specs. The table currently only has information for the hang structured list specs.
- I would also add specs to the table for the Icon left and right padding.
- In the Selectable image, the icon needs to be called out in magenta as being 16px in size.
Co-authored-by: Lauren Rice <[email protected]>
Co-authored-by: Lauren Rice <[email protected]>
This reverts commit eb6a4f7.
Hi Lauren!
Thanks again! |
Hi @laurenmrice! I spoke with @tay1orjones to clarify a couple of points:
The padding issue might take some time to resolve. In the meantime, I'll go ahead and |
Closes #15775
For ref: Figma file
Changelog
New
Color & Interactive states section
Structure section
Changed
Color, Interactive states & Structure section