Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add tag section to color token page #3933

Merged
merged 4 commits into from
Feb 28, 2024
Merged

docs: add tag section to color token page #3933

merged 4 commits into from
Feb 28, 2024

Conversation

laurenmrice
Copy link
Member

Closes #3932

  • Added Tag component color tokens to the bottom of the Color > Tokens page
    • We wanted to move these from the Tag style tab to the tokens page to clear some space for the additions of the new tag variants.

New

  • Tag section and table of component color tokens.

@vercel Vercel
Copy link

vercel bot commented Feb 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 2:28pm

@laurenmrice laurenmrice marked this pull request as ready for review February 23, 2024 18:51
@laurenmrice laurenmrice requested review from a team as code owners February 23, 2024 18:51
Kritvi-bhatia17
Kritvi-bhatia17 approved these changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

andreancardona
andreancardona reviewed Feb 26, 2024
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good on the website!

alisonjoseph
alisonjoseph approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@kodiakhq kodiakhq bot merged commit eb92833 into carbon-design-system:main Feb 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kritvi-bhatia17 Kritvi-bhatia17 Kritvi-bhatia17 approved these changes

@andreancardona andreancardona andreancardona approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@kingtraceyj kingtraceyj Awaiting requested review from kingtraceyj

@guidari guidari Awaiting requested review from guidari guidari was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add component level color tokens for tag to the color tokens table
4 participants
@laurenmrice @alisonjoseph @andreancardona @Kritvi-bhatia17