Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React Tutorial: Replace deprecated layout token with spacing token #2711

Merged
merged 1 commit into from
Jan 25, 2022
Merged

React Tutorial: Replace deprecated layout token with spacing token #2711

merged 1 commit into from
Jan 25, 2022

Commits on Jan 23, 2022

  1. Replace deprecated layout token with spacing token 

    One of the code examples uses the scss variables `$layout-05` for vertical padding/spacing. 
No mention of the layout token system is made in the tutorial (only the spacing tokens are referenced). 
It seems that the layout tokens are deprecated, and it's a bit confusing for tutorial users to see a rogue example of the layout token with no context or explanation.
Suggest replacing it with $spacing-10 (equivalent rem).
    @jicjames
    jicjames authored Jan 23, 2022
    Configuration menu
    Copy the full SHA
    b2d806a View commit details
    Browse the repository at this point in the history