Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add experimental ListSection component from IDL #2324

Merged
merged 5 commits into from
May 19, 2021

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented May 18, 2021

closes #2323

This PR adds an experimental implementation of what a ListSection component might look like so we can see where it works or is falling short.

To view the test page, add /test/list-section/ to the preview URL.

@vpicone vpicone requested a review from a team May 18, 2021 22:27
@vpicone vpicone requested a review from a team as a code owner May 18, 2021 22:27
@vercel
Copy link

vercel bot commented May 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/CgiNYT6fj6dyNVdDMTaUSbK8uGhj
✅ Preview: https://carbondesignsy-git-fork-vpicone-idl-list-comp-carbon-des-9c95e2.vercel.app

Copy link
Contributor

@janchild janchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great to me!

gatsby-config.js Outdated Show resolved Hide resolved
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

src/components/ListSection/ListSection.module.scss Outdated Show resolved Hide resolved
@vpicone vpicone merged commit fd9656c into carbon-design-system:main May 19, 2021
@vpicone vpicone deleted the idl-list-comp branch May 19, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a section list component primitives for creating IDL-style list layouts
3 participants