-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
status indicator pattern #2294
status indicator pattern #2294
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/AxVFzv3kCZNAFyYWq2XjvGFSqogd |
DCO Assistant Lite bot All contributors have signed the DCO. |
Looks good to me, why don't we remove the nav-items entry so we can 'soft' ship this. Then I'll add the sidenav entry when I add the tables. We might want to be more explicit than using equal symbols under accessibility? https://carbondesignsystem-kv8avyeky-carbon-design-system.vercel.app/patterns/status-indicator-pattern/#accessibility |
@jeanservaas that's the idea behind removing it from the nav-items. We can publish the page without surfacing it in the side nav until the tables are ready. |
Full copy edit and revision.
eb966ef
to
9754045
Compare
@jeanservaas I temporarily removed the entry from the sidebar. When it's ready we can "soft launch" it and I can open a new PR for the tables. Reviewers: You can still see the page by manually adding |
@vpicone can you put back the .yaml file on the status indicator page? We’re not going to soft launch it, there’s really no point in a soft launch without the tables and colors in there |
Copy pasting from slack: The reason is so that I can create a fresh PR with new reviewers for the code. There’s no harm in publishing it, it’s not like people are going to randomly type in the exact URL. And if they do, there’s not nuclear launch codes, it’s just under construction. For reviewers, you can access the new page here: |
I have read the DCO document and I hereby sign the DCO. |
Made a new issue to finish this off here: #2366 |
TO DO:
Closes # #2199
ADDITIONS:
Sorry vince, I don't have an issue for this, I thought I could handle it in markdown but I cannot.
Light values
Dark values