Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(breadcrumb): demo matches usage guidelines #2157

Merged
merged 1 commit into from
Mar 3, 2021
Merged

fix(breadcrumb): demo matches usage guidelines #2157

merged 1 commit into from
Mar 3, 2021

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Feb 26, 2021

Closes #2125

Changed

  • Breadcrumb demo shows current page demo without trailing slash

Reviewers

  • Test out live demo in the usage and code tabs for Breadcrumb component

@jnm2377 jnm2377 requested a review from a team February 26, 2021 21:55
@jnm2377 jnm2377 requested a review from a team as a code owner February 26, 2021 21:55
@vercel
Copy link

vercel bot commented Feb 26, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/Cgs1kZndWWLLLphDeXWiVcF6G4BS
✅ Preview: https://carbondesignsy-git-fork-jnm2377-update-breadcrumb-demo-c-f3b249.vercel.app

tw15egan
tw15egan approved these changes Mar 1, 2021
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 453e7ff into carbon-design-system:main Mar 3, 2021
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@jnm2377 @natashadecoste
fix(breadcrumb): demo matches usage guidelines (carbon-design-system#…
8c4b4d5 
…2157)
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@jnm2377 @natashadecoste
fix(breadcrumb): demo matches usage guidelines (carbon-design-system#…
4fd997e 
…2157)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillianhowarth jillianhowarth jillianhowarth approved these changes

@tw15egan tw15egan tw15egan approved these changes

@emyarod emyarod emyarod approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breadcrumbs live demo is misleading
5 participants
@jnm2377 @joshblack @emyarod @tw15egan @jillianhowarth