Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): audit-1591-breadcrumbs-usage-header-id #2150

Merged
merged 3 commits into from
Mar 3, 2021
Merged

fix(docs): audit-1591-breadcrumbs-usage-header-id #2150

merged 3 commits into from
Mar 3, 2021

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Feb 19, 2021 •
edited
Loading

Closes #1591

Changelog

  • Updates headers from MDX to H3 elements with unique ID's
  • Multiple header ID's were causing an accessibility violation

TESTING:

  • Run Accessibility Checker on Components --> Breadcrumb --> Style and make sure the violation seen in the issue is no longer present

@andreancardona andreancardona requested a review from a team February 19, 2021 19:12
@andreancardona andreancardona requested a review from a team as a code owner February 19, 2021 19:12
@vercel
Copy link

vercel bot commented Feb 19, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/6fajEXVZXiaC8epH1h8EVJW11cm6
✅ Preview: https://carbondesignsy-git-fork-andreancardona-1591-breadcrumbs-d00bd2.vercel.app

@andreancardona andreancardona mentioned this pull request Feb 19, 2021
Closed
62 tasks
@andreancardona andreancardona mentioned this pull request Feb 19, 2021
Closed
Base automatically changed from master to main February 24, 2021 23:14
@kodiakhq kodiakhq bot merged commit e25239f into carbon-design-system:main Mar 3, 2021
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@andreancardona @kodiakhq @natashadecoste
fix(docs): audit-1591-breadcrumbs-usage-header-id (carbon-design-syst…
a8aa00d 
…em#2150)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
@andreancardona @kodiakhq @natashadecoste
fix(docs): audit-1591-breadcrumbs-usage-header-id (carbon-design-syst…
fa872c1 
…em#2150)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@jillianhowarth jillianhowarth jillianhowarth approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

audit-avt1-breadcrumb: h3 id in use - color, typography, id
5 participants
@andreancardona @joshblack @jillianhowarth @dakahn @tw15egan