fix(checkbox): usage update #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenmrice
requested review from
jnm2377 and
andreancardona
and removed request for
a team
|
Deploy preview for carbon-website ready! Built with commit ce273ec |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/carbon-website/cgmtvglew |
ghost
requested review from
laurenmrice
requested review from
emyarod
and removed request for
jnm2377,
andreancardona and
tw15egan
emyarod
reviewed
Apr 21, 2020
joshblack
reviewed
Apr 21, 2020
jeanservaas
reviewed
Apr 21, 2020
There was a problem hiding this comment.
Looking good. you're a star...
just a couple of updates to images to use the new templates that I used for Anna's, I also added these images to your file and will shoot it back to you. I attached the images here. In a couple of them, I added a selected checkbox into the mix just to JAZZ THINGS UP. very minor.
- on thing to note, I'm trying to standardize this now IBM [Product Name] in the header... I will of course be making templates for these as soon as I can but that's how jan wants to do it.
- On the spacing tip, since you're really talking about using checkboxes in a form, I wouldn't show it in browser... which will make things a whole lot easier, I'd show it more like we show it in form... instead of putting radio buttons in there, I'd work in checkboxes, but otherwise it can be the same... and maybe we do the teal instead of the magenta... since (is that the color of our spacing tokens?) I have to change my form images anyway. I put that image in your file also. (It does not need to be as elaborate as the form one either... could have fewer elements.
- ps also, no plex mono in images anymore for spacing, mike wants us to go with Plex Sans because it doesn't take up so much space.
janchild
reviewed
Apr 21, 2020
janchild
reviewed
Apr 24, 2020
janchild
approved these changes
Apr 24, 2020
joshblack
approved these changes
Apr 27, 2020
added 17 commits
April 27, 2020 11:41
natashadecoste
pushed a commit
to natashadecoste/carbon-website
that referenced
this pull request
May 19, 2021
* added new images and new documentation * fix image and update links * update image size * update images and update content * update click target image * update content for interactions * update spacing image * content edits * update to wrapping image * update token names and lead sentence * update interaction content * update group label content * update screen reader content * content edits * update placement image * image update * content update Co-authored-by: Lauren Rice <[email protected]>
natashadecoste
pushed a commit
to natashadecoste/carbon-website
that referenced
this pull request
May 19, 2021
* added new images and new documentation * fix image and update links * update image size * update images and update content * update click target image * update content for interactions * update spacing image * content edits * update to wrapping image * update token names and lead sentence * update interaction content * update group label content * update screen reader content * content edits * update placement image * image update * content update Co-authored-by: Lauren Rice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkbox usage content update:
-New images
-New docs
Closes #1067