-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v11: add and update size images #2408
Comments
Examples of components that have size images already:
Button and data table both have stylized size images. We're going to ignore those guys for now and leave them as is. |
Updated images Need the final review @aagonzales |
They look good, just two things.
|
Github request |
Task
Create size images on the following V11 style tab pages.
ButtonSkip for nowData tableSkip for nowModalSkip for nowStructured listSkip for nowTabsSkip for nowHow to create images:
This image will use the fixed image component on the website (we'll worry about this later) and needs an art board width of 736px.
Image sizes
Image size should follow one of these ratios:
Image layout
The fixed image component keeps the size of the image true to pixel size and just adds white space to either side of the image as it grows. For this reason we do not recommend using horizontal rules to divide the components up like we do in a lot of our usage images. The size variants should just be evenly spaced (not too tight at least 32px is not more between variants) and centered in the image. The width of the component itself is up for interoperation but should be at least 32px (48px is better)from the edges of the image. Don't over stretch the component, it should look natural.
Image spec
Example from: https://v11.carbondesignsystem.com/components/dropdown/style#sizes
Exporting images
component-style-size
Existing assets
Either open these assets through Box Drive to edit them and the images will be automatically added OR you can download the files and work locally then add them into the master file on Box Drive later.
If needed, pull in components from the Carbon libraries. If size variants don't exist yet in the library then draw them for the image (detach existing size and edit to correct size).
The text was updated successfully, but these errors were encountered: