Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

feat(breadcrumb): introduce overflow menu #948

Merged
merged 2 commits into from
Feb 14, 2022
Merged

feat(breadcrumb): introduce overflow menu #948

merged 2 commits into from
Feb 14, 2022

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

#442

Description

Introduce horizontal overflow menu for breadcrumb
Screen Shot 2022-02-10 at 3 49 16 PM

Changelog

New

  • added breadcrumb overflow menu for each of the stories and updated docs
  • created a new component bx-breadcrumb-overflow-menu
  • added styles for overflow in breadcrumb

@ariellalgilmore ariellalgilmore requested a review from a team as a code owner February 10, 2022 22:51
@ariellalgilmore ariellalgilmore requested review from emyarod and removed request for a team February 10, 2022 22:51
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/948/index.html

Built with commit: adff79c54b779172d0f20d2c5cac9abc33927ebb

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for Carbon Web Components - Angular:
https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/948/index.html

Built with commit: adff79c54b779172d0f20d2c5cac9abc33927ebb

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/948/index.html

Built with commit: adff79c54b779172d0f20d2c5cac9abc33927ebb

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for Carbon Web Components - React:
https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/948/index.html

Built with commit: adff79c54b779172d0f20d2c5cac9abc33927ebb

emyarod
emyarod reviewed Feb 11, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would we want to handle keyboard nav for overflow menu before merging this or would a follow up PR be more preferable? related https://github.com/carbon-design-system/carbon-web-components/issues/103

@emyarod emyarod mentioned this pull request Feb 11, 2022
Closed
@ariellalgilmore
Copy link
Member Author

ariellalgilmore commented Feb 11, 2022 •
edited
Loading

would we want to handle keyboard nav for overflow menu before merging this or would a follow up PR be more preferable? related carbon-design-system/carbon-for-ibm-dotcom#9807

I think handling carbon-design-system/carbon-for-ibm-dotcom#9807 in a follow-up pr is fine. this really isn't touching the actual overflow-menu just adjusting styles to allow for users to also use it here.

emyarod
emyarod approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good! looks good to me!

RichKummer
RichKummer approved these changes Feb 14, 2022
View reviewed changes
Copy link

@RichKummer RichKummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @ariellalgilmore!

@ariellalgilmore ariellalgilmore added Ready to merge Label for the pull requests that are ready to merge and removed Needs design approval 👀 eyes needed labels Feb 14, 2022
@kodiakhq kodiakhq bot merged commit cab6e54 into main Feb 14, 2022
@kodiakhq kodiakhq bot deleted the feat/breadcrumb-overflow-menu branch February 14, 2022 19:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RichKummer RichKummer RichKummer approved these changes

@emyarod emyarod emyarod approved these changes

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ariellalgilmore @ibmdotcom-bot @emyarod @RichKummer