Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

chore: remove custom skipLibCheck #894

Merged
merged 2 commits into from
Nov 24, 2021
Merged

chore: remove custom skipLibCheck #894

merged 2 commits into from
Nov 24, 2021

Conversation

abdonrd
Copy link
Collaborator

@abdonrd abdonrd commented Nov 24, 2021

Remove custom skipLibCheck.

We should remove the // @ts-ignore, but meanwhile, at least we remove the skipLibCheck.

@abdonrd abdonrd requested a review from a team as a code owner November 24, 2021 19:00
@abdonrd abdonrd requested review from kennylam, BrunnoM7 and RichKummer and removed request for a team November 24, 2021 19:00
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 24, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/894/index.html

Built with commit: 7673dca468adb32f1b42fa152ad3cde021534745

jeffchew
jeffchew approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @abdonrd !

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 24, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - React:
https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/894/index.html

Built with commit: 7673dca468adb32f1b42fa152ad3cde021534745

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Nov 24, 2021
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/894/index.html

Built with commit: 7673dca468adb32f1b42fa152ad3cde021534745

@kodiakhq kodiakhq bot merged commit 52af223 into master Nov 24, 2021
@kodiakhq kodiakhq bot deleted the skipLibCheck branch November 24, 2021 19:57
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for Carbon Web Components - Angular:
https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/894/index.html

Built with commit: 7673dca468adb32f1b42fa152ad3cde021534745

@jeffchew jeffchew mentioned this pull request Dec 6, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffchew jeffchew jeffchew approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@BrunnoM7 BrunnoM7 Awaiting requested review from BrunnoM7 BrunnoM7 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdonrd @ibmdotcom-bot @jeffchew