Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

chore(dependencies): update eslint-config-airbnb-base #774

Merged
merged 4 commits into from
Nov 10, 2021
Merged

chore(dependencies): update eslint-config-airbnb-base #774

merged 4 commits into from
Nov 10, 2021

Conversation

abdonrd
Copy link
Collaborator

@abdonrd abdonrd commented Nov 9, 2021 •
edited
Loading

Update eslint-config-airbnb-base.

  • Removing use strict because eslint-config-airbnb-base update.

Update ESLint & Prettier.

I had to upgrade from eslint-config-carbon-base to eslint-config-carbon in order to upgrade Prettier to v2 and the ESLint dependencies.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 9, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/774/index.html

Built with commit: 6cb73219cc1759614a95745bf8b8d864ada3e720

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 9, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/774/index.html

Built with commit: 6cb73219cc1759614a95745bf8b8d864ada3e720

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 9, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - React:
https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/774/index.html

Built with commit: 969b313256e34449c5a856deb52438b3fb700782

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 9, 2021 •
edited
Loading

Deploy preview created for Carbon Web Components - Angular:
https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/774/index.html

Built with commit: 969b313256e34449c5a856deb52438b3fb700782

@abdonrd abdonrd force-pushed the lint branch 3 times, most recently from b7ed6c9 to 0c82537 Compare November 10, 2021 08:43
@abdonrd abdonrd changed the title chore(dependencies): update eslint & prettier chore(dependencies): update eslint dependencies Nov 10, 2021
@abdonrd abdonrd marked this pull request as ready for review November 10, 2021 08:46
@abdonrd abdonrd requested a review from a team as a code owner November 10, 2021 08:46
@abdonrd abdonrd requested review from photodow, annawen1 and andysherman2121 and removed request for a team November 10, 2021 08:46
@abdonrd abdonrd changed the title chore(dependencies): update eslint dependencies chore(dependencies): update eslint-config-airbnb-base Nov 10, 2021
@abdonrd abdonrd added the Ready to merge Label for the pull requests that are ready to merge label Nov 10, 2021
@abdonrd abdonrd requested a review from jeffchew November 10, 2021 16:08
jeffchew
jeffchew approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew mentioned this pull request Nov 10, 2021
Closed
@kodiakhq kodiakhq bot merged commit 58fe6e5 into master Nov 10, 2021
@kodiakhq kodiakhq bot deleted the lint branch November 10, 2021 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffchew jeffchew jeffchew approved these changes

@photodow photodow Awaiting requested review from photodow photodow was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@andysherman2121 andysherman2121 Awaiting requested review from andysherman2121 andysherman2121 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdonrd @ibmdotcom-bot @jeffchew