Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(masthead): remove aria-haspopup from profile menu for VO #9562

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ class DDSMastheadProfile extends HostListenerMixin(FocusMixin(StableSelectorMixi
tabindex="0"
class="${prefix}--header__menu-item ${prefix}--header__menu-title"
href="javascript:void 0"
aria-haspopup="menu"
aria-expanded="${String(Boolean(expanded))}"
aria-label="${ifDefined(triggerLabel)}"
@click=${handleClick}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
```
<a
aria-expanded="false"
aria-haspopup="menu"
aria-label="User profile"
class="bx--header__menu-item bx--header__menu-title"
href="javascript:void 0"
Expand All @@ -27,7 +26,6 @@
```
<a
aria-expanded="true"
aria-haspopup="menu"
aria-label="User profile"
class="bx--header__menu-item bx--header__menu-title"
href="javascript:void 0"
Expand Down