Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text-cta): add visually-hidden helper text #9461

Merged
merged 10 commits into from
Oct 28, 2022
Merged

fix(text-cta): add visually-hidden helper text #9461

merged 10 commits into from
Oct 28, 2022

Conversation

andy-blum
Copy link
Contributor

Related Ticket(s)

Fixes #8296

Description

Adds visually-hidden helper text. React text CTAs render the text along side the link's contents and web components render the text adjacent to the icon. Links that have an aria-label are not impacted by this change.

Changelog

Changed

  • Accessibility improvements to text CTAs (React & Web Components)

@andy-blum andy-blum added package: react Work necessary for the Carbon for IBM.com react components package accessibility Has accessibility requirement package: web components Work necessary for the IBM.com Library web components package 👀 eyes needed hacktoberfest labels Oct 6, 2022
@andy-blum andy-blum requested a review from a team as a code owner October 6, 2022 03:02
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 6, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/9461/index.html

Built with commit: a8c8533f21d722e9f65d67ef5c1fd5427e03a55d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 6, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9461/index.html

Built with commit: a8c8533f21d722e9f65d67ef5c1fd5427e03a55d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 6, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9461/index.html

Built with commit: a8c8533f21d722e9f65d67ef5c1fd5427e03a55d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 6, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9461/index.html

Built with commit: a8c8533f21d722e9f65d67ef5c1fd5427e03a55d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 6, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9461/index.html

Built with commit: a8c8533f21d722e9f65d67ef5c1fd5427e03a55d

IgnacioBecerra
IgnacioBecerra approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @andy-blum!

RichKummer
RichKummer approved these changes Oct 14, 2022
View reviewed changes
Copy link

@RichKummer RichKummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉🎉

@IgnacioBecerra IgnacioBecerra added the Ready to merge Label for the pull requests that are ready to merge label Oct 18, 2022
@RichKummer RichKummer mentioned this pull request Oct 21, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022 •
edited
Loading

DCO Assistant Lite bot All Contributors have signed the CLA.

@RichKummer
Copy link

I have read the DCO document and I hereby sign the DCO.

@RichKummer
Copy link

recheck

@kodiakhq kodiakhq bot merged commit e1cb87b into carbon-design-system:main Oct 28, 2022
@gopinathan-n
Copy link

Closing this issue as The SR announces the help text. However will open A new issue for the way the help text is Worded.

@andy-blum andy-blum deleted the fix/cta-aria-labels branch February 20, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@RichKummer RichKummer RichKummer approved these changes

Assignees
No one assigned
Labels
accessibility Has accessibility requirement hacktoberfest hacktoberfest-accepted package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CTA]: aria labels when changing cta-type
6 participants
@andy-blum @ibmdotcom-bot @RichKummer @gopinathan-n @IgnacioBecerra @ariellalgilmore