Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(card-pictogram): show body copy on both pictogram positions #8359

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

proeung
Copy link
Contributor

@proeung proeung commented Feb 23, 2022

Related Ticket(s)

#8302

Description

  • This PR fixes the issue where animation is not being applied to Card Pictorgram with the top position. This was an issue seen within the Web Component (React Wrapper).

Changelog

Changed

  • Set the body copy knob to show for both top and bottom position and not just bottom

Testing

  • Visit the Web Components (React Wrapper) storybook preview
  • Navigate to carbon-for-ibm-dotcom/canary/web-components-react/?path=/story/components-card--pictogram
  • Ensure that the body copy and animation get render correct for the "top" and " bottom" pictogram positions.

@proeung proeung added package: web components Work necessary for the IBM.com Library web components package 👀 eyes needed labels Feb 23, 2022
@proeung proeung requested a review from a team as a code owner February 23, 2022 15:39
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @proeung!

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 23, 2022

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 23, 2022

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 23, 2022

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 23, 2022

Copy link

@RichKummer RichKummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @proeung !

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 23, 2022

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Feb 23, 2022
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 24, 2022

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8359/index.html

Built with commit: 6508e2a6203bd0ac80f30cb865ceac112d3f482a

@kodiakhq kodiakhq bot merged commit 96f027f into carbon-design-system:main Feb 24, 2022
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8359/index.html

Built with commit: 6508e2a6203bd0ac80f30cb865ceac112d3f482a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 eyes needed package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants