Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(footer): change cypress intercept for translation to use raw data #8244

Merged
merged 4 commits into from
Feb 10, 2022
Merged

fix(footer): change cypress intercept for translation to use raw data #8244

merged 4 commits into from
Feb 10, 2022

Conversation

jeffchew
Copy link
Member

@jeffchew jeffchew commented Feb 9, 2022

Related Ticket(s)

No related issue

Description

This is a followup to the cypress e2e tests for Footer. In some cases the sessionStorage isn't being used and the cy.intercept is caught instead. In this case, it should use the raw response from the translation repo.

Changelog

Changed

  • Changed fixture for translation API to use raw response data

@jeffchew jeffchew added the dev Needs some dev work label Feb 9, 2022
@jeffchew jeffchew requested a review from a team as a code owner February 9, 2022 20:01
@jeffchew jeffchew self-assigned this Feb 9, 2022
@jeffchew jeffchew requested a review from emyarod February 9, 2022 20:01
emyarod
emyarod approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just needs matching file names I believe

packages/react/tests/e2e-storybook/cypress/support/index.js Show resolved Hide resolved
packages/web-components/tests/e2e-storybook/cypress/support/index.js Show resolved Hide resolved
@emyarod emyarod mentioned this pull request Feb 9, 2022
Closed
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8244/index.html

Built with commit: 61272d880f63eed6fa8271c2e30d2a7f05d4331f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8244/index.html

Built with commit: 61272d880f63eed6fa8271c2e30d2a7f05d4331f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8244/index.html

Built with commit: 61272d880f63eed6fa8271c2e30d2a7f05d4331f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8244/index.html

Built with commit: 61272d880f63eed6fa8271c2e30d2a7f05d4331f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8244/index.html

Built with commit: 61272d880f63eed6fa8271c2e30d2a7f05d4331f

@jeffchew
Copy link
Member Author

jeffchew commented Feb 9, 2022

Something is not jiving with the React tests, investigating...

image

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 10, 2022 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8244/index.html

Built with commit: 61272d880f63eed6fa8271c2e30d2a7f05d4331f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 10, 2022 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8244/index.html

Built with commit: 61272d880f63eed6fa8271c2e30d2a7f05d4331f

@jeffchew
Copy link
Member Author

Turns out that Cypress didn't like the setting of sessionStorage, so that was removed and now fully relies on the raw translation fixture.

@IgnacioBecerra IgnacioBecerra added the Ready to merge Label for the pull requests that are ready to merge label Feb 10, 2022
@kodiakhq kodiakhq bot merged commit 444b310 into carbon-design-system:main Feb 10, 2022
@jeffchew jeffchew deleted the fix/footer-e2e-part-deux branch February 10, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@emyarod emyarod emyarod approved these changes

Assignees

@jeffchew jeffchew

Labels
dev Needs some dev work Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffchew @ibmdotcom-bot @emyarod @IgnacioBecerra