Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(yarn): upgrade yarn to 1.22.17 #8234

Merged
merged 6 commits into from
Feb 11, 2022
Merged

chore(yarn): upgrade yarn to 1.22.17 #8234

merged 6 commits into from
Feb 11, 2022

Conversation

jeffchew
Copy link
Member

@jeffchew jeffchew commented Feb 8, 2022

Related Ticket(s)

No related issue

Description

We are seeing connectivity issues with yarn install on our CI, this is an attempt to see if this might help at all.

Changelog

Changed

  • Upgrade yarn to 1.22.17

@jeffchew jeffchew requested a review from a team as a code owner February 8, 2022 18:24
@jeffchew jeffchew requested a review from emyarod February 8, 2022 18:24
@jeffchew jeffchew self-assigned this Feb 8, 2022
@jeffchew jeffchew added the dev Needs some dev work label Feb 8, 2022
emyarod
emyarod reviewed Feb 8, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 1 question about the version

.yarnrc
@@ -2,8 +2,8 @@
# yarn lockfile v1


version v1.19.0
lastUpdateCheck 1597082923381
version "1.22.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to match up with the release version in yarn-path?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm yeah, this was auto generated and I set the policy to use 1.22.17. Not sure why it says 1.22.10...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha, I guess it should be fine since it was autogenerated and still the same minor version

@emyarod emyarod mentioned this pull request Feb 8, 2022
Closed
emyarod
emyarod approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me if the version mismatch is just from yarn's autogenerating!

.yarnrc
@@ -2,8 +2,8 @@
# yarn lockfile v1


version v1.19.0
lastUpdateCheck 1597082923381
version "1.22.10"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha, I guess it should be fine since it was autogenerated and still the same minor version

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8234/index.html

Built with commit: df697dfe820e9b4fce2714a01c95a67cd8fd9a19

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8234/index.html

Built with commit: df697dfe820e9b4fce2714a01c95a67cd8fd9a19

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8234/index.html

Built with commit: df697dfe820e9b4fce2714a01c95a67cd8fd9a19

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8234/index.html

Built with commit: ae2f41d5f1b9964d4687685040859ae96f47f0b3

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8234/index.html

Built with commit: df697dfe820e9b4fce2714a01c95a67cd8fd9a19

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 10, 2022 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8234/index.html

Built with commit: df697dfe820e9b4fce2714a01c95a67cd8fd9a19

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 10, 2022 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8234/index.html

Built with commit: df697dfe820e9b4fce2714a01c95a67cd8fd9a19

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Feb 10, 2022
@kodiakhq kodiakhq bot merged commit 04c9594 into carbon-design-system:main Feb 11, 2022
@jeffchew jeffchew deleted the chore/upgrade-yarn branch March 30, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

Assignees

@jeffchew jeffchew

Labels
dev Needs some dev work Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffchew @ibmdotcom-bot @emyarod