Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(styles): remove carbon expressive storybook #8231

Merged
merged 3 commits into from
Feb 8, 2022
Merged

chore(styles): remove carbon expressive storybook #8231

merged 3 commits into from
Feb 8, 2022

Conversation

jeffchew
Copy link
Member

@jeffchew jeffchew commented Feb 7, 2022

Related Ticket(s)

No related issue

Description

Since we are no longer supporting the carbon expressive theme in our repo, this removes the storybook app we installed awhile ago.

Changelog

Removed

  • Storybook and related dependencies for Carbon Expressive theme in styles package

@jeffchew jeffchew requested a review from a team as a code owner February 7, 2022 22:00
@jeffchew jeffchew requested a review from emyarod February 7, 2022 22:00
@jeffchew jeffchew self-assigned this Feb 7, 2022
@jeffchew jeffchew added the dev Needs some dev work label Feb 7, 2022
emyarod
emyarod approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@emyarod emyarod mentioned this pull request Feb 7, 2022
Closed
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 7, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8231/index.html

Built with commit: 5eb82a8849b66da09e3fee265cdfc0d61226f344

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 7, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8231/index.html

Built with commit: 5eb82a8849b66da09e3fee265cdfc0d61226f344

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 7, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8231/index.html

Built with commit: 5eb82a8849b66da09e3fee265cdfc0d61226f344

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 7, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8231/index.html

Built with commit: 5eb82a8849b66da09e3fee265cdfc0d61226f344

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 7, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8231/index.html

Built with commit: 5eb82a8849b66da09e3fee265cdfc0d61226f344

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Feb 8, 2022
@jeffchew jeffchew merged commit 1aacb71 into carbon-design-system:main Feb 8, 2022
@jeffchew jeffchew deleted the chore/remove-styles-storybook branch February 8, 2022 20:33
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8231/index.html

Built with commit: 648754f843f69f5a5402705b5ad8ee4d014bb54a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

Assignees

@jeffchew jeffchew

Labels
dev Needs some dev work Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffchew @ibmdotcom-bot @emyarod