Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(feature-section-card-link): remove incorrect role #8197

Merged
merged 4 commits into from
Feb 5, 2022
Merged

fix(feature-section-card-link): remove incorrect role #8197

merged 4 commits into from
Feb 5, 2022

Conversation

jkaeser
Copy link
Member

@jkaeser jkaeser commented Feb 2, 2022

Related Ticket(s)

Resolves #8010

Description

The DDSLinkList and DDSFeatureSectionCardLink components had incorrect role attributes, which caused a number of a11y errors to be reported when running the yarn lint:a11y script. Fixing the roles on these two components resolves any errors related to incorrect usages of "listitem" roles.

Changelog

Changed

  • Added role="list" to DDSLinkList component
  • Removed role="listitem" from DDSFeatureSectionCardLink component

@jkaeser jkaeser requested a review from a team as a code owner February 2, 2022 21:40
@jkaeser jkaeser requested a review from emyarod February 2, 2022 21:40
@jkaeser jkaeser added 👀 eyes needed package: web components Work necessary for the IBM.com Library web components package labels Feb 2, 2022
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 2, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8197/index.html

Built with commit: 156ffa310d4471f483c09695d49bfa3d0c635b33

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 2, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8197/index.html

Built with commit: 156ffa310d4471f483c09695d49bfa3d0c635b33

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 2, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8197/index.html

Built with commit: 156ffa310d4471f483c09695d49bfa3d0c635b33

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 2, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8197/index.html

Built with commit: 156ffa310d4471f483c09695d49bfa3d0c635b33

@proeung proeung added the accessibility Has accessibility requirement label Feb 2, 2022
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 2, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8197/index.html

Built with commit: 156ffa310d4471f483c09695d49bfa3d0c635b33

@proeung
Copy link
Contributor

proeung commented Feb 2, 2022

@jkaeser Thanks for opening this PR!

Can you run yarn test:a11y and see if listitem error is affecting other components outside of dds-link-list and dds-feature-section-card-link? According to this user (see - #8010 (comment)), this error is happening on dds-top-nav-item and dds-legal-nav-item as well.

@proeung proeung self-requested a review February 2, 2022 22:19
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 3, 2022 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8197/index.html

Built with commit: 156ffa310d4471f483c09695d49bfa3d0c635b33

@jeffchew jeffchew changed the title Fix/a11y list item error 8010 fix(feature-section-card-link): remove incorrect role Feb 3, 2022
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 3, 2022 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8197/index.html

Built with commit: 156ffa310d4471f483c09695d49bfa3d0c635b33

emyarod
emyarod approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@emyarod emyarod mentioned this pull request Feb 4, 2022
Closed
proeung
proeung approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@proeung proeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@proeung proeung added the Ready to merge Label for the pull requests that are ready to merge label Feb 4, 2022
@kodiakhq kodiakhq bot merged commit e68d4a1 into carbon-design-system:main Feb 5, 2022
@jkaeser jkaeser deleted the fix/a11y-list-item-error-8010 branch February 9, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@proeung proeung proeung approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore

Assignees
No one assigned
Labels
accessibility Has accessibility requirement 👀 eyes needed package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
4 participants
@jkaeser @ibmdotcom-bot @proeung @emyarod