Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(video-player): move focus to iframe after Kaltura embed #8181

Merged
merged 5 commits into from
Feb 1, 2022
Merged

fix(video-player): move focus to iframe after Kaltura embed #8181

merged 5 commits into from
Feb 1, 2022

Conversation

andy-blum
Copy link
Member

Related Ticket(s)

Fixes #8077

Description

Updates video-player-container to move focus to newly inserted iframe after embedding to prevent iOS issue where focus must leave web component before its shadowroot updates can be interactive

Changelog

Changed

  • fixed issue video-player focus issue in iOS

@andy-blum andy-blum requested a review from a team as a code owner January 31, 2022 21:37
@andy-blum andy-blum requested a review from emyarod January 31, 2022 21:37
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 31, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8181/index.html

Built with commit: 8333c0b29da64399b62735583ba6a13352a73667

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 31, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8181/index.html

Built with commit: 8333c0b29da64399b62735583ba6a13352a73667

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 31, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8181/index.html

Built with commit: 8333c0b29da64399b62735583ba6a13352a73667

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 31, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8181/index.html

Built with commit: 8333c0b29da64399b62735583ba6a13352a73667

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 31, 2022 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8181/index.html

Built with commit: 8333c0b29da64399b62735583ba6a13352a73667

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 1, 2022 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8181/index.html

Built with commit: 8333c0b29da64399b62735583ba6a13352a73667

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 1, 2022 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8181/index.html

Built with commit: 8333c0b29da64399b62735583ba6a13352a73667

kennylam
kennylam approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @andy-blum!

emyarod
emyarod approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@emyarod emyarod mentioned this pull request Feb 1, 2022
Closed
@proeung proeung added adopter: AEM used when component or pattern will be used by this adopter package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge labels Feb 1, 2022
@kodiakhq kodiakhq bot merged commit c4f18c1 into carbon-design-system:main Feb 1, 2022
@andy-blum andy-blum deleted the fix/video-player branch February 4, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@kennylam kennylam kennylam approved these changes

Assignees
No one assigned
Labels
adopter: AEM used when component or pattern will be used by this adopter package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
5 participants
@andy-blum @ibmdotcom-bot @kennylam @emyarod @proeung