Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): remove tsickle #8175

Merged
merged 1 commit into from
Jan 31, 2022
Merged

chore(deps): remove tsickle #8175

merged 1 commit into from
Jan 31, 2022

Conversation

jeffchew
Copy link
Member

Related Ticket(s)

No related issue

Description

It doesn't appear that tsickle is being used, and rather than having it upgraded by renovatebot, this is a PR to remove it instead.

Changelog

Removed

  • tsickle

@jeffchew jeffchew added the dev Needs some dev work label Jan 31, 2022
@jeffchew jeffchew self-assigned this Jan 31, 2022
@jeffchew jeffchew requested a review from a team as a code owner January 31, 2022 20:52
@jeffchew jeffchew requested a review from emyarod January 31, 2022 20:52
emyarod
emyarod approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@emyarod emyarod mentioned this pull request Jan 31, 2022
Closed
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8175/index.html

Built with commit: 8f35d276a943391e51165975afa2642d6de08512

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8175/index.html

Built with commit: 8f35d276a943391e51165975afa2642d6de08512

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8175/index.html

Built with commit: 8f35d276a943391e51165975afa2642d6de08512

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8175/index.html

Built with commit: 8f35d276a943391e51165975afa2642d6de08512

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8175/index.html

Built with commit: 8f35d276a943391e51165975afa2642d6de08512

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8175/index.html

Built with commit: 8f35d276a943391e51165975afa2642d6de08512

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 31, 2022
@kodiakhq kodiakhq bot merged commit 1d02b5d into carbon-design-system:main Jan 31, 2022
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8175/index.html

Built with commit: 8f35d276a943391e51165975afa2642d6de08512

@jeffchew jeffchew deleted the chore/remove-tsickle branch February 21, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

Assignees

@jeffchew jeffchew

Labels
dev Needs some dev work Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffchew @ibmdotcom-bot @emyarod