Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(github-actions): move slack webhook url to under slack action #8060

Merged
merged 2 commits into from
Jan 18, 2022
Merged

fix(github-actions): move slack webhook url to under slack action #8060

merged 2 commits into from
Jan 18, 2022

Conversation

jeffchew
Copy link
Member

Related Ticket(s)

No related issue

Description

The slack webhook as a global environment variable was getting burned into the React artifacts when building to Github Pages. This exposes the secret which isn't desired.

This PR moves the environment variable specifically under the Slack action in the workflow to avoid this.

Changelog

Changed

  • deploy-canary.yml
  • deploy-next.yml

@jeffchew jeffchew added the dev Needs some dev work label Jan 18, 2022
@jeffchew jeffchew self-assigned this Jan 18, 2022
@jeffchew jeffchew requested a review from a team as a code owner January 18, 2022 16:19
emyarod
emyarod approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@emyarod emyarod mentioned this pull request Jan 18, 2022
Closed
@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 18, 2022
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 18, 2022 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/8060/index.html

Built with commit: d4740708baa66b768d7cb280a9e7e59f11cca4d1

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 18, 2022 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8060/index.html

Built with commit: d4740708baa66b768d7cb280a9e7e59f11cca4d1

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 18, 2022 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8060/index.html

Built with commit: d4740708baa66b768d7cb280a9e7e59f11cca4d1

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 18, 2022 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8060/index.html

Built with commit: d4740708baa66b768d7cb280a9e7e59f11cca4d1

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8060/index.html

Built with commit: d4740708baa66b768d7cb280a9e7e59f11cca4d1

@kodiakhq kodiakhq bot merged commit 2bf3bcd into carbon-design-system:main Jan 18, 2022
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8060/index.html

Built with commit: d4740708baa66b768d7cb280a9e7e59f11cca4d1

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8060/index.html

Built with commit: d4740708baa66b768d7cb280a9e7e59f11cca4d1

@jeffchew jeffchew deleted the fix/slack-webhook branch February 21, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@oliviaflory oliviaflory Awaiting requested review from oliviaflory oliviaflory is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees

@jeffchew jeffchew

Labels
dev Needs some dev work Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffchew @ibmdotcom-bot @emyarod