Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): multiple fixes for browserstack automate #7807

Merged
merged 4 commits into from
Dec 2, 2021
Merged

test(e2e): multiple fixes for browserstack automate #7807

merged 4 commits into from
Dec 2, 2021

Conversation

jeffchew
Copy link
Member

@jeffchew jeffchew commented Dec 2, 2021

Related Ticket(s)

No related issue

Description

This fixes a number of issues with browserstack and how it handles tests. React seems fine, still sorting through web components but can probably do a followup PR to do additional fixes if needed.

Changelog

Changed

  • Multiple fixes across e2e tests

@jeffchew jeffchew added the dev Needs some dev work label Dec 2, 2021
@jeffchew jeffchew added this to the Sprint 21-24 milestone Dec 2, 2021
@jeffchew jeffchew self-assigned this Dec 2, 2021
@jeffchew jeffchew requested a review from a team as a code owner December 2, 2021 19:35
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/7807/index.html

Built with commit: f17e7f141ea22a8ea3ab95d51452f9b895dcbd8a

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7807/index.html

Built with commit: f17e7f141ea22a8ea3ab95d51452f9b895dcbd8a

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7807/index.html

Built with commit: f17e7f141ea22a8ea3ab95d51452f9b895dcbd8a

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7807/index.html

Built with commit: f17e7f141ea22a8ea3ab95d51452f9b895dcbd8a

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7807/index.html

Built with commit: f17e7f141ea22a8ea3ab95d51452f9b895dcbd8a

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7807/index.html

Built with commit: f17e7f141ea22a8ea3ab95d51452f9b895dcbd8a

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7807/index.html

Built with commit: f17e7f141ea22a8ea3ab95d51452f9b895dcbd8a

IgnacioBecerra
IgnacioBecerra approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffchew thanks for the fixes!

@IgnacioBecerra IgnacioBecerra mentioned this pull request Dec 2, 2021
Closed
@jeffchew jeffchew merged commit 800f951 into master Dec 2, 2021
@jeffchew jeffchew deleted the test/browserstack-e2e-fixes branch December 2, 2021 22:11
@mwanberg mwanberg mentioned this pull request Mar 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@emyarod emyarod Awaiting requested review from emyarod emyarod was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees

@jeffchew jeffchew

Labels
dev Needs some dev work
Projects
None yet
Milestone
Sprint 21-24
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffchew @ibmdotcom-bot @IgnacioBecerra