Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cla-assistant): updated kodiakhq name for allowlist #7607

Merged
merged 3 commits into from
Nov 5, 2021
Merged

fix(cla-assistant): updated kodiakhq name for allowlist #7607

merged 3 commits into from
Nov 5, 2021

Conversation

jeffchew
Copy link
Member

@jeffchew jeffchew commented Nov 5, 2021 •
edited
Loading

Related Ticket(s)

No related issue

Description

There looks to be an issue trying to get kodiakhq to be ignored in the CLA:

image

In addition, signing the CLA was unclear before, made updates so that it should be clearer and is now working.

Changelog

Changed

  • cla.yml allowlist change for kodiakhq[bot]
  • Added better instructions for users to sign properly
  • Changed the message to the default signature comment

@jeffchew jeffchew added the dev Needs some dev work label Nov 5, 2021
@jeffchew jeffchew added this to the Sprint 21-22 milestone Nov 5, 2021
@jeffchew jeffchew self-assigned this Nov 5, 2021
@jeffchew jeffchew requested a review from a team as a code owner November 5, 2021 17:22
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7607/index.html

Built with commit: 77e8f11599f49c8f1311dec91896f2c42ce954e1

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7607/index.html

Built with commit: 77e8f11599f49c8f1311dec91896f2c42ce954e1

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7607/index.html

Built with commit: 77e8f11599f49c8f1311dec91896f2c42ce954e1

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 5, 2021 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7607/index.html

Built with commit: 77e8f11599f49c8f1311dec91896f2c42ce954e1

emyarod
emyarod approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/7607/index.html

Built with commit: 77e8f11599f49c8f1311dec91896f2c42ce954e1

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Nov 5, 2021
@jeffchew jeffchew merged commit 84b1468 into carbon-design-system:master Nov 5, 2021
@jeffchew jeffchew deleted the fix/cla-assistant branch November 5, 2021 19:23
@emyarod emyarod mentioned this pull request Nov 5, 2021
Closed
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7607/index.html

Built with commit: 77e8f11599f49c8f1311dec91896f2c42ce954e1

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7607/index.html

Built with commit: 77e8f11599f49c8f1311dec91896f2c42ce954e1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@DragosRistici DragosRistici Awaiting requested review from DragosRistici DragosRistici was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees

@jeffchew jeffchew

Labels
dev Needs some dev work Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
Sprint 21-22
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffchew @ibmdotcom-bot @emyarod