Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expressive-modal): ensure waiting for transitionend event #5189

Merged
merged 3 commits into from
Feb 17, 2021
Merged

fix(expressive-modal): ensure waiting for transitionend event #5189

merged 3 commits into from
Feb 17, 2021

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Feb 17, 2021

Related Ticket(s)

Refs #5173.

Description

Changes the "focus on the primary focusable element" logic in <dds-expressive-modal> to wait for transitionend event. Without it, the attempt to focus fails.

Also changes <dds-locale-modal> to make <dds-region-item> as the primary focusable element.

Changelog

Changed

  • The "focus on the primary focusable element" logic in <dds-expressive-modal> to wait for transitionend event.
  • <dds-locale-modal> to make <dds-region-item> as the primary focusable element.

@asudoh
fix(expressive-modal): ensure waiting for transitionend event
f4d9e74 
Changes the "focus on the primary focusable element" logic in
`<dds-expressive-modal>` to wait for `transitionend` event. Without it,
the attempt to focus fails.

Also changes `<dds-locale-modal>` to make `<dds-region-item>` as the
primary focusable element.

Refs carbon-design-system#5173.
@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Feb 17, 2021
@asudoh asudoh requested a review from kennylam February 17, 2021 00:11
@asudoh asudoh mentioned this pull request Feb 17, 2021
Merged
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 17, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/5189/index.html

Built with commit: f8644e6fc5108d177acf96edc36c83c635eeee73

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 17, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/5189/index.html

Built with commit: f8644e6fc5108d177acf96edc36c83c635eeee73

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 17, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/5189/index.html

Built with commit: f8644e6fc5108d177acf96edc36c83c635eeee73

kennylam
kennylam reviewed Feb 17, 2021
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping in on this @asudoh! Can you target the release branch please release/v1.16.0?

@asudoh asudoh changed the base branch from master to release/v1.16.0 February 17, 2021 08:00
@asudoh
Copy link
Contributor Author

asudoh commented Feb 17, 2021

Can you target the release branch please release/v1.16.0?

Done - Thank you for pointing it out @kennylam!

kennylam
kennylam approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @asudoh!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Feb 17, 2021
@kodiakhq kodiakhq bot merged commit a50a2e6 into carbon-design-system:release/v1.16.0 Feb 17, 2021
@asudoh asudoh deleted the expressive-modal-focus branch February 17, 2021 09:53
@guilhermelMoraes guilhermelMoraes mentioned this pull request Feb 17, 2021
Closed
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
@asudoh @IgnacioBecerra
fix(expressive-modal): ensure waiting for transitionend event (carbon…
8e6eb37 
…-design-system#5189)

### Related Ticket(s)

Refs carbon-design-system#5173.

### Description

Changes the "focus on the primary focusable element" logic in `<dds-expressive-modal>` to wait for `transitionend` event. Without it, the attempt to focus fails.

Also changes `<dds-locale-modal>` to make `<dds-region-item>` as the primary focusable element.

### Changelog

**Changed**

- The "focus on the primary focusable element" logic in `<dds-expressive-modal>` to wait for `transitionend` event.
- `<dds-locale-modal>` to make `<dds-region-item>` as the primary focusable element.
@kennylam kennylam mentioned this pull request Feb 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asudoh @ibmdotcom-bot @kennylam