fix(masthead): customtypeahead api fix #5168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennylam
added
the
package: react
|
Deploy preview created for package Built with commit: 703151bc64705c9c66cf2c93c27e0f768930ddd6 |
|
Deploy preview created for package Built with commit: 703151bc64705c9c66cf2c93c27e0f768930ddd6 |
|
Deploy preview created for package Built with commit: 703151bc64705c9c66cf2c93c27e0f768930ddd6 |
kennylam
added
the
Ready to merge
IgnacioBecerra
pushed a commit
to IgnacioBecerra/ibm-dotcom-library
that referenced
this pull request
Feb 22, 2021
### Description Updates masthead search `customTypeAheadApi` to be fully on the application side. When using a custom API, it will no longer pass through `SearchTypeaheadAPI` at all. This allows users to pass a full API including any necessary query params that were not defined in `SearchTypeaheadAPI`. With this change the use of environment variables is no longer necessary. ### Changelog **Changed** - moves `customTypeAheadApi` out of `SearchTypeaheadAPI` - update jest environment variables - section titles no longer appear when there are no section items <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates masthead search
customTypeAheadApito be fully on the application side. When using a custom API, it will no longer pass throughSearchTypeaheadAPIat all. This allows users to pass a full API including any necessary query params that were not defined inSearchTypeaheadAPI. With this change the use of environment variables is no longer necessary.Changelog
Changed
customTypeAheadApiout ofSearchTypeaheadAPI