Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(link-list-section): heading now aligns with top items line #5117

Merged
merged 3 commits into from
Feb 10, 2021
Merged

fix(link-list-section): heading now aligns with top items line #5117

merged 3 commits into from
Feb 10, 2021

Conversation

raphaelamadeu-zz
Copy link
Contributor

Related Ticket(s)

#5012

Description

LinkListSection heading now aligns with the top items, as per AEM specs.

@raphaelamadeu-zz raphaelamadeu-zz added the package: web components Work necessary for the IBM.com Library web components package label Feb 8, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/5117/index.html

Built with commit: d5d01e20a5a337584c47891986c91f801122c254

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/5117/index.html

Built with commit: d5d01e20a5a337584c47891986c91f801122c254

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/5117/index.html

Built with commit: d5d01e20a5a337584c47891986c91f801122c254

kennylam
kennylam reviewed Feb 9, 2021
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raphaelamadeu I'm not seeing the change?

image

@raphaelamadeu-zz
Copy link
Contributor Author

@raphaelamadeu I'm not seeing the change?

image

Hey @kennylam thanks for the review, previously there was top padding on the left container, this pr removes that padding, so it's above the original position now.

kennylam
kennylam approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks @raphaelamadeu!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Feb 10, 2021
@kodiakhq kodiakhq bot merged commit 3e4999e into carbon-design-system:master Feb 10, 2021
@guilhermelMoraes guilhermelMoraes mentioned this pull request Feb 12, 2021
Closed
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
@raphaelamadeu-zz @IgnacioBecerra
fix(link-list-section): heading now aligns with top items line (carbo…
595286e 
…n-design-system#5117)

### Related Ticket(s)

carbon-design-system#5012 

### Description

`LinkListSection` heading now aligns with the top items, as per AEM specs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@asudoh asudoh Awaiting requested review from asudoh

@jeffchew jeffchew Awaiting requested review from jeffchew

@andysherman2121 andysherman2121 Awaiting requested review from andysherman2121

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raphaelamadeu-zz @ibmdotcom-bot @kennylam @asudoh