fix(cta): add default aria-label for different types #5096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview created for package Built with commit: b5367f3e5d3a5b76fa2edd3891b6f53b83a40fda |
|
Deploy preview created for package Built with commit: b5367f3e5d3a5b76fa2edd3891b6f53b83a40fda |
|
Deploy preview created for package Built with commit: b5367f3e5d3a5b76fa2edd3891b6f53b83a40fda |
IgnacioBecerra
added
the
package: react
IgnacioBecerra
changed the title
IgnacioBecerra
requested review from
annawen1,
ariellalgilmore and
guilhermelMoraes
ariellalgilmore
added
the
Ready to merge
IgnacioBecerra
added a commit
to IgnacioBecerra/ibm-dotcom-library
that referenced
this pull request
Feb 22, 2021
…ystem#5096) ### Related Ticket(s) carbon-design-system#2728 carbon-design-system#2384 carbon-design-system#4142 carbon-design-system#4060 ### Description Added an `aria-label` to inform screen reader users the CTA about the type of link they are focused on, such as `external`, `video`, or `download`. The default label is provided in English by default, but the message can be a custom translation that is passed in using the `ariaLabel` prop by adopters. This PR also changes the `role` of LinkList to `listitem` with the use of a custom `ariaRole` prop to specify different roles depending on the use within components. ### Changelog **New** - added `ariaLabel` to `CTA` component for adopters to customize the message in a different language - added `ariaProp` to `CTA` component to set a custom role depending on the use in other components **Changed** - `aria-label` message for CTA Text and Card - set `role='listitem` in `LinkList` <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
#2728
#2384
#4142
#4060
Description
Added an
aria-labelto inform screen reader users the CTA about the type of link they are focused on, such asexternal,video, ordownload. The default label is provided in English by default, but the message can be a custom translation that is passed in using theariaLabelprop by adopters.This PR also changes the
roleof LinkList tolistitemwith the use of a customariaRoleprop to specify different roles depending on the use within components.Changelog
New
ariaLabeltoCTAcomponent for adopters to customize the message in a different languageariaProptoCTAcomponent to set a custom role depending on the use in other componentsChanged
aria-labelmessage for CTA Text and Cardrole='listiteminLinkList