Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(masthead): update codesandbox example #5091

Merged
merged 1 commit into from
Feb 4, 2021
Merged

chore(masthead): update codesandbox example #5091

merged 1 commit into from
Feb 4, 2021

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented Feb 4, 2021

Description

Fixes scss import errors from carbon-components that were preventing the example from rendering properly.

Changelog

New

  • .sassrc to fix import paths

Changed

  • use latest version of carbon-components

Removed

  • redundant masthead-search example

@kennylam kennylam requested a review from asudoh February 4, 2021 13:09
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/5091/index.html

Built with commit: 287fc4288377d9fb63503e137cf63856657d7ca8

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/5091/index.html

Built with commit: 287fc4288377d9fb63503e137cf63856657d7ca8

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/5091/index.html

Built with commit: 287fc4288377d9fb63503e137cf63856657d7ca8

asudoh
asudoh approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @kennylam for the fix!

@asudoh asudoh merged commit b35605c into carbon-design-system:master Feb 4, 2021
@kennylam kennylam deleted the chore/masthead-example-wc branch February 4, 2021 13:50
@jeffchew jeffchew mentioned this pull request Feb 4, 2021
Closed
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
@kennylam @IgnacioBecerra
chore(masthead): update codesandbox example (carbon-design-system#5091)
0b8fd05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennylam @ibmdotcom-bot @asudoh