fix(card): added focus on click #5083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphaelamadeu-zz
requested review from
kennylam,
asudoh,
jeffchew and
guilhermelMoraes
|
Deploy preview created for package Built with commit: fe92e953153cb1f29df1aa7609aaabaa4cd08c76 |
|
Deploy preview created for package Built with commit: fe92e953153cb1f29df1aa7609aaabaa4cd08c76 |
|
Deploy preview created for package Built with commit: fe92e953153cb1f29df1aa7609aaabaa4cd08c76 |
jeffchew
added
the
Ready to merge
IgnacioBecerra
pushed a commit
to IgnacioBecerra/ibm-dotcom-library
that referenced
this pull request
Feb 22, 2021
### Related Ticket(s) carbon-design-system#4744 ### Description Added focus on click for the card component, as Safari would faltly consider `body` as the active element when the card was clicked, this caused an accessibility bug where the focus would be trapped inside `ExpressiveModal` even after closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
#4744
Description
Added focus on click for the card component, as Safari would faltly consider
bodyas the active element when the card was clicked, this caused an accessibility bug where the focus would be trapped insideExpressiveModaleven after closed.