Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(content-block-headlines): use CSS grid for layout #5078

Merged
merged 4 commits into from
Feb 4, 2021
Merged

refactor(content-block-headlines): use CSS grid for layout #5078

merged 4 commits into from
Feb 4, 2021

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Feb 3, 2021

Related Ticket(s)

Refs #4960.

Description

Use CSS grid for layout for <dds-content-block-headlines> to ensure correct Carbon grid alignment and simplify the markup.

Changelog

Changed

  • A change to use CSS grid for layout for <dds-content-block-headlines>.

@asudoh
refactor(content-block-headlines): use CSS grid for layout
d452dcc 
Use CSS grid for layout for `<dds-content-block-headlines>` to ensure
correct Carbon grid alignment and simplify the markup.

Refs carbon-design-system#4960.
@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Feb 3, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 3, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/5078/index.html

Built with commit: 275330ff2bffedf70617e71db17934669e73a38c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 4, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/5078/index.html

Built with commit: 275330ff2bffedf70617e71db17934669e73a38c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 4, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/5078/index.html

Built with commit: 275330ff2bffedf70617e71db17934669e73a38c

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "React (experimental)":
https://ibmdotcom-react-experimental.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/5078/index.html

Built with commit: 275330ff2bffedf70617e71db17934669e73a38c

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "Web Components (experimental)":
https://ibmdotcom-web-components-experimental.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/5078/index.html

Built with commit: 275330ff2bffedf70617e71db17934669e73a38c

kennylam
kennylam approved these changes Feb 4, 2021
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @asudoh!

@kennylam kennylam merged commit 75c2c7a into carbon-design-system:master Feb 4, 2021
@asudoh asudoh mentioned this pull request Feb 16, 2021
Closed
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
@asudoh @kennylam @IgnacioBecerra
refactor(content-block-headlines): use CSS grid for layout (carbon-de…
62c1fd0 
…sign-system#5078)

Use CSS grid for layout for `<dds-content-block-headlines>` to ensure
correct Carbon grid alignment and simplify the markup.

Refs carbon-design-system#4960.

Co-authored-by: kennylam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

Assignees
No one assigned
Labels
feature flag package: web components Work necessary for the IBM.com Library web components package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asudoh @ibmdotcom-bot @kennylam