Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(web-components): add notes on TypeScript definition files #5044

Merged
merged 6 commits into from
Feb 2, 2021

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Feb 1, 2021

Related Ticket(s)

Refs #4988.

Description

Adds implementation notes for TypeScript definition files in @carbon/ibmdotcom-web-components so that new developers can quickly understand the difference from regular NPM packages.

Changelog

New

  • Implementation notes for TypeScript definition files in @carbon/ibmdotcom-web-components.

Adds implementation notes for TypeScript definition files in
`@carbon/ibmdotcom-web-components` so that new developers can quickly
understand the difference from regular NPM packages.

Refs carbon-design-system#4988.
@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Feb 1, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 1, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 1, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 1, 2021

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @asudoh!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Feb 2, 2021
@kodiakhq kodiakhq bot merged commit 2c70a97 into carbon-design-system:master Feb 2, 2021
@asudoh asudoh deleted the implnotes-dts branch February 3, 2021 00:03
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
…n-design-system#5044)

### Related Ticket(s)

Refs carbon-design-system#4988.

### Description

Adds implementation notes for TypeScript definition files in `@carbon/ibmdotcom-web-components` so that new developers can quickly understand the difference from regular NPM packages.

### Changelog

**New**

- Implementation notes for TypeScript definition files in `@carbon/ibmdotcom-web-components`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants