fix(content-block-cards): fix margin in smallest breakpoint #5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes wrong margin in `<dds-content-block-cards>` in its smallest breakpoint. Also migrates the internal layout to CSS grid to eliminate the negative margin adjustment of heading vs. cards. Refs carbon-design-system#4959.
asudoh
added
the
package: web components
|
Deploy preview created for package Built with commit: 8b491e947318c667c05804b7cd441610e016a852 |
|
Deploy preview created for package Built with commit: 8b491e947318c667c05804b7cd441610e016a852 |
|
Deploy preview created for package Built with commit: 8b491e947318c667c05804b7cd441610e016a852 |
kennylam
approved these changes
Jan 30, 2021
kennylam
added
the
Ready to merge
IgnacioBecerra
pushed a commit
to IgnacioBecerra/ibm-dotcom-library
that referenced
this pull request
Feb 22, 2021
…esign-system#5014) ### Related Ticket(s) Refs carbon-design-system#4959. ### Description Fixes wrong margin in `<dds-content-block-cards>` in its smallest breakpoint. Also migrates the internal layout to CSS grid to eliminate the negative margin adjustment of heading vs. cards. ### Changelog **Changed** - Change to fix wrong margin in `<dds-content-block-cards>` in its smallest breakpoint. - Change to migrate the internal layout to CSS grid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Refs #4959.
Description
Fixes wrong margin in
<dds-content-block-cards>in its smallest breakpoint. Also migrates the internal layout to CSS grid to eliminate the negative margin adjustment of heading vs. cards.Changelog
Changed
<dds-content-block-cards>in its smallest breakpoint.