Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storybook): fix web component Storybook container classes #5004

Merged
merged 6 commits into from
Jan 26, 2021
Merged

chore(storybook): fix web component Storybook container classes #5004

merged 6 commits into from
Jan 26, 2021

Conversation

kennylam
Copy link
Member

Related Ticket(s)

#5002

Description

Update conditional classes for web component Storybook container.

Changelog

Changed

  • dds-ce-demo-devenv--container is now optional for web component stories

@kennylam kennylam added the package: web components Work necessary for the IBM.com Library web components package label Jan 25, 2021
@kennylam kennylam changed the title chore(storybook): fix container responsive styles chore(storybook): fix web component Storybook container classes Jan 25, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/5004/index.html

Built with commit: 6581d8000572d011b75db10f95514e36512ba33f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/5004/index.html

Built with commit: 6581d8000572d011b75db10f95514e36512ba33f

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/5004/index.html

Built with commit: 6581d8000572d011b75db10f95514e36512ba33f

andysherman2121
andysherman2121 approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@andysherman2121 andysherman2121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work kenny 👍

asudoh
asudoh approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @kennylam on jumping into this!

@asudoh
Copy link
Contributor

asudoh commented Jan 25, 2021

@kennylam @ariellalgilmore Did we want to cut another RC? Or not because we see this is a storybook issue? CC @RobertaJHahn

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Jan 26, 2021
@ariellalgilmore
Copy link
Member

@kennylam @ariellalgilmore Did we want to cut another RC? Or not because we see this is a storybook issue? CC @RobertaJHahn

@asudoh We are pushing this to the next release because it's just a storybook issue

@kodiakhq kodiakhq bot merged commit cc9709d into carbon-design-system:master Jan 26, 2021
@kennylam kennylam deleted the chore/web-components-storybook-container-styles branch January 26, 2021 20:48
@jeffchew jeffchew mentioned this pull request Feb 1, 2021
Closed
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
@kennylam @IgnacioBecerra
chore(storybook): fix web component Storybook container classes (carb…
43759b0 
…on-design-system#5004)

### Related Ticket(s)

carbon-design-system#5002 

### Description

Update conditional classes for web component Storybook container.

### Changelog

**Changed**

- `dds-ce-demo-devenv--container` is now optional for web component stories

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysherman2121 andysherman2121 andysherman2121 approved these changes

@asudoh asudoh asudoh approved these changes

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kennylam @ibmdotcom-bot @asudoh @ariellalgilmore @andysherman2121