Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(web-components): implementation notes for React integration #5000

Merged
merged 3 commits into from
Jan 26, 2021
Merged

docs(web-components): implementation notes for React integration #5000

merged 3 commits into from
Jan 26, 2021

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Jan 25, 2021

Related Ticket(s)

Refs #4975.

Description

Add notes on how React integration for @carbon/ibmdotcom-web-components works, and how build procedure automates in this area.

Changelog

New

  • Notes on how React integration for @carbon/ibmdotcom-web-components works, and how build procedure automates in this area.

@asudoh
docs(web-components): implementation notes for React integration
7e2e7cd 
Add notes on how React integration for
`@carbon/ibmdotcom-web-components` works, and how build procedure
automates in this area.

Refs carbon-design-system#4975.
@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Jan 25, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/5000/index.html

Built with commit: ae5dd507616b048d2d55e0c85f820649e28e181d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/5000/index.html

Built with commit: ae5dd507616b048d2d55e0c85f820649e28e181d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/5000/index.html

Built with commit: ae5dd507616b048d2d55e0c85f820649e28e181d

annawen1
annawen1 approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @asudoh!

@asudoh asudoh added the Ready to merge Label for the pull requests that are ready to merge label Jan 26, 2021
@kodiakhq kodiakhq bot removed the Ready to merge Label for the pull requests that are ready to merge label Jan 26, 2021
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jan 26, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the Ready to merge label.

@asudoh asudoh added the Ready to merge Label for the pull requests that are ready to merge label Jan 26, 2021
@kodiakhq kodiakhq bot merged commit 3e5c259 into carbon-design-system:master Jan 26, 2021
@asudoh asudoh deleted the implnotes-react-wrapper branch January 27, 2021 00:43
@jeffchew jeffchew mentioned this pull request Feb 1, 2021
Closed
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
@asudoh @IgnacioBecerra
docs(web-components): implementation notes for React integration (car…
42b4fd6 
…bon-design-system#5000)

### Related Ticket(s)

Refs carbon-design-system#4975.

### Description

Add notes on how React integration for `@carbon/ibmdotcom-web-components` works, and how build procedure automates in this area.

### Changelog

**New**

- Notes on how React integration for `@carbon/ibmdotcom-web-components` works, and how build procedure automates in this area.
@asudoh asudoh mentioned this pull request Feb 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 approved these changes

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asudoh @ibmdotcom-bot @annawen1 @kennylam