Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(left-nav): resetting items expanded after close hamb. menu #4956

Conversation

guilhermelMoraes
Copy link
Contributor

Related Ticket(s)

Web components: Masthead with L1 - Hamburger menu not getting reset, on closing from sub-menu options. #4592

Description

Resetting items expanded after close hamb. menu

@guilhermelMoraes guilhermelMoraes added the package: web components Work necessary for the IBM.com Library web components package label Jan 21, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 21, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 21, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 21, 2021

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @guilhermelMoraes!

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guilhermelMoraes for the update!

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @guilhermelMoraes for the update!

@guilhermelMoraes guilhermelMoraes added the Ready to merge Label for the pull requests that are ready to merge label Jan 22, 2021
@kodiakhq kodiakhq bot merged commit e9b7d8b into carbon-design-system:master Jan 22, 2021
@guilhermelMoraes guilhermelMoraes deleted the fix/reset-hamburguer-menu branch January 22, 2021 17:11
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
…n-design-system#4956)

### Related Ticket(s)

Web components: Masthead with L1 - Hamburger menu not getting reset, on closing from sub-menu options. carbon-design-system#4592

### Description

Resetting items expanded after close hamb. menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants