Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(profile): update profile requx actions, types, and reducers naming and unit tests #4926

Merged
merged 5 commits into from
Jan 20, 2021
Merged

fix(profile): update profile requx actions, types, and reducers naming and unit tests #4926

merged 5 commits into from
Jan 20, 2021

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Jan 19, 2021 •
edited
Loading

Related Ticket(s)

Change profile endpoint on Carbon Masthead for signed in state #4701

Description

Update naming and unit tests from feedback: #4909

Changelog

Changed

  • update getUserStatus action to loadUserStatus in accordance to naming strategy
  • create Unauthenticated const in ProfileAPI type
  • use request instead of status for the setRequestUserStatusInProgress and setUserStatus actions

@annawen1 annawen1 changed the base branch from master to release/v1.15.0 January 19, 2021 22:39
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 19, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4926/index.html

Built with commit: 3d0b89d4a224de16bbbfaca753e279b88673a688

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 19, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4926/index.html

Built with commit: 3d0b89d4a224de16bbbfaca753e279b88673a688

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 19, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4926/index.html

Built with commit: 3d0b89d4a224de16bbbfaca753e279b88673a688

@asudoh
Copy link
Contributor

asudoh commented Jan 20, 2021

Looking good so far, and the CI is passing! Thank you for making this change quickly @annawen1!

@annawen1 annawen1 marked this pull request as ready for review January 20, 2021 14:02
asudoh
asudoh approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @annawen1!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 20, 2021
@kodiakhq kodiakhq bot merged commit c824634 into carbon-design-system:release/v1.15.0 Jan 20, 2021
@ariellalgilmore ariellalgilmore mentioned this pull request Jan 20, 2021
Closed
@annawen1 annawen1 deleted the fix/update-redux-actions-names-and-test branch February 10, 2021 18:19
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
@annawen1 @IgnacioBecerra
fix(profile): update profile requx actions, types, and reducers namin…
2545a46 
…g and unit tests (carbon-design-system#4926)

### Related Ticket(s)

Change profile endpoint on Carbon Masthead for signed in state carbon-design-system#4701

### Description

Update naming and unit tests from feedback: carbon-design-system#4909

### Changelog

**Changed**

- update `getUserStatus` action to `loadUserStatus` in accordance to naming strategy
- create `Unauthenticated` const in ProfileAPI type
- use `request` instead of `status` for the `setRequestUserStatusInProgress` and `setUserStatus` actions

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

@kennylam kennylam Awaiting requested review from kennylam

@jeffchew jeffchew Awaiting requested review from jeffchew

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annawen1 @ibmdotcom-bot @asudoh @jeffchew