Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(github-workflow): add profile host env var to various testing envs #4923

Merged
merged 1 commit into from
Jan 19, 2021
Merged

chore(github-workflow): add profile host env var to various testing envs #4923

merged 1 commit into from
Jan 19, 2021

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Jan 19, 2021 •
edited
Loading

Related Ticket(s)

Change profile endpoint on Carbon Masthead for signed in state #4701

Description

Add the profile host env var to various testing envs
previously added the variable to only react testing envs

deploy-canary:

  • react-experimental
  • react-rtl
  • web-components
  • web-components-rtl
  • web-components-experimental
  • web-components-react
  • services

deploy-staging:

  • web-components

@annawen1 annawen1 requested a review from jeffchew January 19, 2021 17:51
@annawen1 annawen1 changed the base branch from master to release/v1.15.0 January 19, 2021 17:51
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4923/index.html

Built with commit: 4c7e716849fed778a68e1290a4354fe26b9b79f5

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4923/index.html

Built with commit: 4c7e716849fed778a68e1290a4354fe26b9b79f5

jeffchew
jeffchew approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Later on we might want to clear out the env vars that aren't really necessary for various deployments, like services and utilities. They generate JSDocs so those aren't needed. We can address this on master branch but it's not urgent as they are pretty much ignored.

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4923/index.html

Built with commit: 4c7e716849fed778a68e1290a4354fe26b9b79f5

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 19, 2021
@jeffchew jeffchew merged commit 6f3436b into carbon-design-system:release/v1.15.0 Jan 19, 2021
@jeffchew jeffchew deleted the chore/update-git-workflow branch January 19, 2021 21:03
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
@annawen1 @IgnacioBecerra
chore(github-workflow): add profile host env var to various testing e…
33c3fb3 
…nvs (carbon-design-system#4923)

### Related Ticket(s)

Change profile endpoint on Carbon Masthead for signed in state carbon-design-system#4701

### Description

Add the profile host env var to various testing envs
previously added the variable to only react testing envs

deploy-canary:
- react-experimental
- react-rtl
- web-components
- web-components-rtl
- web-components-experimental
- web-components-react
- services

deploy-staging:
- web-components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchew jeffchew jeffchew approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore

@kennylam kennylam Awaiting requested review from kennylam

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annawen1 @ibmdotcom-bot @jeffchew