Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(link-list-section): replaced wrong heading component in storybook #4922

Merged
merged 6 commits into from
Jan 20, 2021
Merged

fix(link-list-section): replaced wrong heading component in storybook #4922

merged 6 commits into from
Jan 20, 2021

Conversation

IgnacioBecerra
Copy link
Contributor

Related Ticket(s)

#4844

Description

Replaced the previous <dds-content-section-heading>component within the Link List Section story to <dds-link-list-heading>.

Also noted that <dds-content-section-heading> didn't have the heading role and included that in this PR.

Changelog

New

  • added role='heading' to <dds-content-section-heading>

Changed

  • replaced wrong heading component for Link List Section within storybook

@IgnacioBecerra IgnacioBecerra added the package: web components Work necessary for the IBM.com Library web components package label Jan 19, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 19, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4922/index.html

Built with commit: 0c30b416dac06553d2d238c132f361914db9fcf9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 19, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4922/index.html

Built with commit: 0c30b416dac06553d2d238c132f361914db9fcf9

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 19, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4922/index.html

Built with commit: 0c30b416dac06553d2d238c132f361914db9fcf9

asudoh
asudoh reviewed Jan 20, 2021
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this @IgnacioBecerra!

packages/web-components/src/components/content-section/content-section-heading.ts
Comment on lines +27 to +29
if (!this.hasAttribute('role')) {
this.setAttribute('role', 'heading');
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add aria-level, too? Here's an example for one representing <h3>.

asudoh
asudoh approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @IgnacioBecerra for the update!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 20, 2021
@jeffchew jeffchew removed the Ready to merge Label for the pull requests that are ready to merge label Jan 20, 2021
@jeffchew
Copy link
Member

@IgnacioBecerra can you check why one of the CI checks are failing?

@asudoh asudoh added the Ready to merge Label for the pull requests that are ready to merge label Jan 20, 2021
@kodiakhq kodiakhq bot merged commit 82f5ec0 into carbon-design-system:master Jan 20, 2021
@jeffchew jeffchew mentioned this pull request Feb 1, 2021
Closed
IgnacioBecerra added a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
@IgnacioBecerra
fix(link-list-section): replaced wrong heading component in storybook (…
3cfda89 
…carbon-design-system#4922)

### Related Ticket(s)
carbon-design-system#4844

### Description

Replaced the previous `<dds-content-section-heading>`component within the Link List Section story to `<dds-link-list-heading>`. 

Also noted that `<dds-content-section-heading>` didn't have the `heading` role and included that in this PR.

### Changelog

**New**

- added `role='heading'` to `<dds-content-section-heading>`

**Changed**

- replaced wrong heading component for Link List Section within storybook

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IgnacioBecerra @ibmdotcom-bot @jeffchew @asudoh