Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(masthead): remove a duplicate rule set #4915

Merged
merged 3 commits into from
Jan 19, 2021
Merged

chore(masthead): remove a duplicate rule set #4915

merged 3 commits into from
Jan 19, 2021

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Jan 16, 2021

Changelog

Removed

  • A duplicate CSS rule set, that was introduced to ensure Carbon core doesn't override masthead top nav item's hover color. Instead of introducing a new CSS rule set, the new code fixes the issue by bumping up the priority of our CSS rule defining masthead top nav color.

@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Jan 16, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 16, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4915/index.html

Built with commit: 4f13747259b997b233a58bd818b8b4c082447544

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 16, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4915/index.html

Built with commit: 4f13747259b997b233a58bd818b8b4c082447544

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 16, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4915/index.html

Built with commit: 4f13747259b997b233a58bd818b8b4c082447544

guilhermelMoraes
guilhermelMoraes approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@guilhermelMoraes guilhermelMoraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@guilhermelMoraes guilhermelMoraes added the Ready to merge Label for the pull requests that are ready to merge label Jan 18, 2021
@kodiakhq kodiakhq bot merged commit 5955cff into carbon-design-system:master Jan 19, 2021
@asudoh asudoh deleted the l1-background-masthead branch January 19, 2021 07:50
@jeffchew jeffchew mentioned this pull request Feb 1, 2021
Closed
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
@asudoh @IgnacioBecerra
chore(masthead): remove a duplicate rule set (carbon-design-system#4915)
8b1a687 
### Changelog

**Removed**

- A duplicate CSS rule set, that was introduced to ensure Carbon core doesn't override masthead top nav item's hover color. Instead of introducing a new CSS rule set, the new code fixes the issue by bumping up the priority of our CSS rule defining masthead top nav color.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhermelMoraes guilhermelMoraes guilhermelMoraes approved these changes

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asudoh @ibmdotcom-bot @guilhermelMoraes